New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageGlass checks for updates it incorrectly #61

Closed
d2phap opened this Issue Jan 1, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@d2phap
Owner

d2phap commented Jan 1, 2016

From John:

I have a small bug report:
every time my ImageGlass checks for updates it incorrectly tells me that my installed version is out-of-date.

I presume this is because it isn't able to get out via the (password authentication required) proxy server at my $WORK.

Logically 3.0.8.19 is more recent than the "1.0.0.0" that it seems to default to when it isn't able to reach the web to get a current version, but it says "1.0.0.0" is newer. Does it only check that the version it retrieves is different from the current version, and assume that if it's different it must be newer? - it doesn't seem to do any numerical comparison of the version strings.

Perhaps you could get it to handle not being able to get online a bit more sensibly - i.e. catch an exception when failing to retrieve a "current" version from the web and display a message saying something like:

"Unable to check for current version online.
Please visit http://imageglass.org/download to check for updates." rather than defaulting to a fake version and then insisting that the fake version is newer than the installed version.

Also, the message at the top of the window isn't grammatical English.
It should either say:
"Your ImageGlass is out of date"
or perhaps:
"Your ImageGlass is outdated"
(the first one is the best)

@d2phap d2phap added the 🐞 bug label Jan 1, 2016

@d2phap d2phap added this to the 3.0.9.19 milestone Jan 1, 2016

d2phap pushed a commit that referenced this issue Jan 1, 2016

Dương Diệu Pháp
Tweak CheckForUpdate function
Issue #61:
- Fix typo grammar mistake
- Update status text
Fix alignment issue of About dialog

@d2phap d2phap closed this Jan 1, 2016

@d2phap d2phap added the 👌 ready label Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment