New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed options specification to force touch events register #42

Merged
merged 5 commits into from Oct 3, 2017

Conversation

2 participants
@nicolas-van

nicolas-van commented Sep 27, 2017

See the discussion in #41

@mbostock

This comment has been minimized.

Show comment
Hide comment
@mbostock

mbostock Sep 27, 2017

Member

Rather than options to the constructor, can you make this a configurable property like drag.filter? Say, drag.touchable with the default being the current implementation, and drag.touchable(true) would make it always-on?

Member

mbostock commented Sep 27, 2017

Rather than options to the constructor, can you make this a configurable property like drag.filter? Say, drag.touchable with the default being the current implementation, and drag.touchable(true) would make it always-on?

@nicolas-van

This comment has been minimized.

Show comment
Hide comment
@nicolas-van

nicolas-van Oct 3, 2017

Hello. It has been done like you proposed.

nicolas-van commented Oct 3, 2017

Hello. It has been done like you proposed.

@mbostock mbostock merged commit cc4aef5 into d3:master Oct 3, 2017

@mbostock

This comment has been minimized.

Show comment
Hide comment
@mbostock

mbostock Oct 3, 2017

Member

Polished a bit and merged. Thank you!

Member

mbostock commented Oct 3, 2017

Polished a bit and merged. Thank you!

mbostock added a commit to d3/d3-zoom that referenced this pull request Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment