Commits on Apr 9, 2011
  1. @mbostock

    Fix a transition bug in bullet chart.

    We were computing the tick join based on the (new) format function, but doesn't
    produce the desired effect: the new format is applied on the old data. Thus, the
    wrong join occurs if, say, the value 0.5 with the new format results in "0". The
    correct join compares the old text content to the new format value.
    mbostock committed Apr 9, 2011
  2. @mbostock

    No initial transition.

    mbostock committed Apr 9, 2011
  3. @mbostock
  4. @mbostock

    Add remove test.

    mbostock committed Apr 9, 2011
  5. @mbostock

    Add insert test.

    mbostock committed Apr 9, 2011
  6. @mbostock
  7. @mbostock

    Merge branch 'bullet'

    mbostock committed Apr 9, 2011
  8. @mbostock
  9. @mbostock
  10. @mbostock

    Separate scales per bullet.

    Rather sharing the x-scale across bullet multiples, compute a separate scale per multiple. This
    gives the user more control over the scale: by setting the range values across multiples (in data),
    the user can precisely control the resulting scales. For transitions, we cache the old scale value
    in a hidden __chart__ attribute. This is a bit of a hack (it might be cleaner to persist it in the
    data of a child element), but it might provide a sticky way for charts to communicate with each
    other in the future, say for performing transitions across chart types.
    mbostock committed Apr 9, 2011
  11. @mbostock

    Remove `parentData`.

    It's equivalent to `parentNode.__data__`, so it's not needed. Technically, this
    is not backwards-compatible, but these two fields on the group object are not
    part of the public API (despite being technically accessible).
    mbostock committed Apr 9, 2011
  12. @jasondavies

    Push bullet chart state into ticks element data.

    This means chart state (the original x-scale) is no longer bound to the
    chart instance, so a single instance can be reused on multiple elements.
    jasondavies committed Apr 9, 2011
Commits on Apr 8, 2011
  1. @mbostock
  2. @mbostock
  3. @mbostock

    Rename var.

    mbostock committed Apr 8, 2011
  4. @jasondavies
  5. @mbostock

    Add another bullet example.

    This example shows how to preserve scales across multiples using a single chart
    instance, as opposed to bullet-multiples which uses distinct chart instances to
    supply separate scales. I still think it'd be better to use a single chart
    instance in both cases, but then I need a different place to hide the scale
    state.
    mbostock committed Apr 8, 2011
  6. @jasondavies

    Merge Mike's changes.

    Conflicts:
    	examples/bullet/bullet-multiples.html
    jasondavies committed Apr 8, 2011
  7. @jasondavies

    Merge Mike's changes.

    Includes hard-coded orientation for simplicity.
    
    Conflicts:
    	examples/bullet/bullet-multiples.html
    jasondavies committed Apr 8, 2011
  8. @mbostock

    Use separate charts for bullet-multiples.

    This way, we get separate scales for the small multiples, which makes sense
    given our data. However, I'm not totally convinced this is the right way to
    implement separate scales, because it's a bit awkward to create separate chart
    instances that look identical. Also, it's unfortunate that the charts are
    stateful; it'd be better to somehow store the scale as data on the nodes, so
    that chart specifications could be more easily reused. Then, there might be a
    method to fix the domain rather than computing the domain per-chart.
    mbostock committed Apr 8, 2011
  9. @mbostock
  10. @mbostock

    Fix bugs in remove & data.

    The remove operator was completely broken in 1.8.6. I will add some tests to
    make sure that doesn't happen again. Also, the data operator was broken if you
    had duplicate keys in your join function; in this case, the duplicate elements
    would not always be removed.
    mbostock committed Apr 8, 2011
  11. @mbostock

    Extract title & subtitle from bullet chart.

    It's nice, but I think it's a bit more flexible to not have it as part of the
    chart specification. This way, people can define titles however they like. It
    might be nice to take a similar approach with reference ticks in the future.
    mbostock committed Apr 8, 2011
  12. @jasondavies

    Cache chart instances.

    jasondavies committed Apr 8, 2011
  13. @jasondavies
  14. @jasondavies
  15. @jasondavies
  16. @jasondavies
  17. @jasondavies

    Simplify bullet multiples example.

    Thanks Mike!
    jasondavies committed Apr 8, 2011
  18. @jasondavies
  19. @jasondavies

    Add some comments.

    jasondavies committed Apr 8, 2011
  20. @jasondavies
  21. @jasondavies
  22. @jasondavies
  23. @jasondavies

    Merge Mike's changes.

    Conflicts:
    	d3.chart.js
    	d3.chart.min.js
    	src/chart/bullet.js
    jasondavies committed Apr 8, 2011