force layout: properly UNSET the .fixed bits: user may be using further ... #798

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@GerHobbelt
Contributor

...bits and those should be kept intact.

(I use the force layout in several places where it was/is extremely handy to use the higher bits for my own augmentations, which depend on the internal 'if (node.fixed) { dont_move_node }' force.layout logic.

One such example is http://bl.ocks.org/3616279 which is a layout which adds 'pinning' baheviour where nodes stick to the dragged-to location when you keep SHIFT or CTRL pressed when stopping the drag (when you try that gist, it has the known issue that it doesn't properly keep/release the pinned state; that's an irrelevant detail of that specific example.)

@mbostock
Member
mbostock commented Sep 5, 2012

Looks good.

@GerHobbelt
Contributor

bump ?

@mbostock
Member

Sorry for the delay. Lost track in a deluge of issues and pull requests. Trying to organize them now.

@mbostock
Member
mbostock commented Feb 6, 2013

Folded into #1062.

@mbostock mbostock closed this Feb 6, 2013
@GerHobbelt
Contributor

Hi Mike,

Thanks for the follow-up! It's much appreciated and sorry to add to that to
the deluge. ;-)
I hope to add to another deluge in due time, but I know how it is, being
completely swamped myself right now.

Met vriendelijke groeten / Best regards,

Ger Hobbelt


web: http://www.hobbelt.com/
http://www.hebbut.net/
mail: ger@hobbelt.com

mobile: +31-6-11 120 978

On Wed, Jan 23, 2013 at 8:50 PM, Mike Bostock notifications@github.comwrote:

Sorry for the delay. Lost track in a deluge of issues and pull requests.
Trying to organize them now.


Reply to this email directly or view it on GitHubhttps://github.com/mbostock/d3/pull/798#issuecomment-12618621.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment