Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow unittest-version be set to 'latest' or empty string #16

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

camalot
Copy link
Contributor

@camalot camalot commented Jan 2, 2024

Allow the unittest-version property to be either an empty string, or latest.

This addresses #15

Copy link
Owner

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution, @camalot! I left a small suggestion, let me know what you think of it. Overall this looks good to me, so I'll leave an approval and wait for your feedback.

action.yml Outdated Show resolved Hide resolved
…nto v2.4-beta

* 'v2.4-beta' of github.com:camalot/helm-unittest-action:
  feat: Allow unittest-version be set to 'latest' or empty string
  feat: Allow unittest-version be set to 'latest' or empty string
@camalot
Copy link
Contributor Author

camalot commented Jan 3, 2024

I think i squashed the commits correctly... if not, let me know.

@d3adb5 d3adb5 merged commit 66140cd into d3adb5:master Jan 4, 2024
8 checks passed
@d3adb5
Copy link
Owner

d3adb5 commented Jan 4, 2024

There were suddenly 4 commits in this PR, so I think something went wrong on your local worktree. Nonetheless, I squashed and merged directly through GitHub. I'll make a release for this. Thank you, @camalot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants