Support edge-to-edge rendering on Android Q+ - #146
Merged
Conversation
d4rken
reviewed
Jul 3, 2023
d4rken
left a comment
d4rken
left a comment
Member
There was a problem hiding this comment.
Looks good on my device ❤️ , I'm open to adding it. Just a few comments where I would like to hear your thoughts.
| <item name="colorPrimaryInverse">@color/md_theme_light_primaryInverse</item> | ||
|
|
||
| <item name="android:navigationBarColor"> | ||
| #B3000000 |
Member
There was a problem hiding this comment.
What do you think about using a color variable here?
Contributor
Author
There was a problem hiding this comment.
Forgot to reply here earlier, but I had just left this here as a fallback for anything below Android 10. Was removed in later commits as it wasn't necessary.
Member
|
lgtm 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This app has been insanely helpful for using AirPods on Android. However, it was missing one small detail: edge-to-edge rendering. Since the release of gesture navigation with Android Q (10), apps can render below the navigation bar for a cleaner and more modern look. I've done this with CAPod and was hoping my changes can be merged with the main repository to provide this experience to all who find and use this app. Here's the difference with using edge-to-edge rendering:
No edge-to-edge
Edge-to-Edge
One of the things I haven't tackled in this pull request is rendering below the camera cutout when in landscape mode. For the purposes of streamlining, I didn't do that yet. I simply wanted to make the app look slightly cleaner.
Please let me know if you have any questions or concerns regarding my changes. I hope this can get merged!