Skip to content

Add PUSH_NOTIFICATIONS permission to AndroidManifest.xml for wearos - #203

Merged
d4rken merged 2 commits into
d4rken-org:mainfrom
kavishdevar:wearos-notification-permission-fix
Jun 26, 2024
Merged

d4rken merged 2 commits into
d4rken-org:mainfrom
kavishdevar:wearos-notification-permission-fix

Conversation

@kavishdevar

Copy link
Copy Markdown
Contributor

Fixes #154 by adding the required uses-permission for push notifications tag in AndroidManifest.xml for wearos.

@kavishdevar kavishdevar changed the title Add PUSH_NOTIFICATIONS permissions to AndroidManifest.xml for wearos Add PUSH_NOTIFICATIONS permission to AndroidManifest.xml for wearos May 20, 2024
@d4rken

d4rken commented May 21, 2024

Copy link
Copy Markdown
Member

Have you tested this? There is no PUSH_NOTIFICATIONS permission in Android.

@kavishdevar

kavishdevar commented May 21, 2024 •

Copy link
Copy Markdown
Contributor Author

This permission was introduced in API Level 33 (Android 13). Refer https://developer.android.com/develop/ui/views/notifications/notification-permission

I have tested it on my Galaxy Watch 6 running WearOS 4 (Android 13)

@rcky844

rcky844 commented Jun 26, 2024

Copy link
Copy Markdown

This permission was introduced in API Level 33 (Android 13). Refer https://developer.android.com/develop/ui/views/notifications/notification-permission

I have tested it on my Galaxy Watch 6 running WearOS 4 (Android 13)

I think you've got the name of it wrong, the page states:
android.permission.POST_NOTIFICATIONS

@kavishdevar

Copy link
Copy Markdown
Contributor Author

Oh, my bad, fixed the typo now.

I actually buit a few builds locally and then forked the repository for the PR. So, I didn't actually test the code that I pushed... Apologies!

@d4rken d4rken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@d4rken
d4rken merged commit 65a7b19 into d4rken-org:main Jun 26, 2024
@kavishdevar
kavishdevar deleted the wearos-notification-permission-fix branch June 26, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use on Samsung 5 watch

3 participants