Fix IRK match flag in AppleFactory - #294
Merged
Merged
Conversation
This commit corrects the `isIRKMatch` flag assignment in `AppleFactory.kt`. Previously, it was hardcoded to `true`. Now, it correctly uses the `isIrkMatch` variable determined by the Identity Resolving Key (IRK) comparison.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incorrect flag assignment in AppleFactory, ensuring that the IRK match flag is set based on the actual IRK comparison.
- Corrects the flag assignment from a hardcoded value to a variable-driven approach
- Addresses issue #290 as referenced in the PR description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit corrects the
isIRKMatchflag assignment inAppleFactory.kt. Previously, it was hardcoded totrue. Now, it correctly uses theisIrkMatchvariable determined by the Identity Resolving Key (IRK) comparison.Fixes #290 (comment)