Refactor GPlay billing error handling and translations - #314
Merged
Conversation
d4rken
commented
Jul 21, 2025
d4rken
commented
Member
- Prevent google play related errors from throwing inside the app-level coroutine scope and crashing the app.
- Show an error pop-up for such errors
This commit introduces localized error messages for Google Play billing issues and refactors the error handling in `UpgradeRepoGplay`. - `BillingException` and `BillingResultException` now implement `HasLocalizedError` to provide user-friendly error messages. - New string translations for billing error labels and descriptions have been added for various languages. - `UpgradeRepoGplay` now includes an `error` field in its `Info` state to propagate billing errors. - The `upgradeInfo` flow in `UpgradeRepoGplay` has been updated with a `retryWhen` operator to handle errors more gracefully. If an error occurs but the pro state was recent, it emits a grace period state. Otherwise, it emits the error. - `OverviewFragmentVM` now observes `upgradeState` and posts any non-pro errors to `errorEvents` for display.
d4rken
force-pushed
the
prevent-gplay-caused-crashes
branch
from
August 30, 2025 14:50
747be28 to
cf9b53e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.