Setup: Gracefully handle QUERY_ALL_PACKAGES permission being optional on some devices - #1033
Merged
Conversation
…e devices Previous we always assumed that QUERY_ALL_PACKAGES was granted (which it should, by default), but Samsung seems to be doing "Just Samsung things ™️" and this may not be the case on some of Samsungs Android 14 ROMs. So let's treat it as potentially optional and catch the error, don't crash, and guide the user to the setup. Closes #1015
d4rken
added
enhancement
Member
Author
|
|
d4rken
changed the title
d4rken
marked this pull request as ready for review
February 25, 2024 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous we always assumed that QUERY_ALL_PACKAGES was granted (which it should, by default), but Samsung seems to be doing "Just Samsung things ™️" and this may not be the case on some of Samsungs Android 14 ROMs. So let's treat it as potentially optional and catch the error, don't crash, and guide the user to the setup.
Closes #1015