AppCleaner: Improve recycle-bin filter on Samsung devices - #1059
Merged
Conversation
Prevent SystemCleaner's "Linux Files" filter from picking up the default trash folder on Samsung devices. Support app specific matching of files in the system's recycle bin folder on Samsung devices e.g.: sdcard/Android/.Trash/<gallery/myfiles etc.>/<trash files> Closes #1057
d4rken
added
enhancement
d4rken
added a commit
that referenced
this pull request
Apr 2, 2024
…age Access Framework filters work with prefix free paths, i.e. they don't care about the specific "sdcard name". #1059 removed the overlap when passing scanned paths to filters, so filters get more path information. Before filters worked with "/sdcard/nextcloud/folderA" -> "folderA" After filters worked with "/sdcard/nextcloud/folderA" -> "nextcloud/folderA" This worked for `LocalPath` but caused a bug with `SAFPath` because paths here are split into a `treeUri` and segments. The path logic failed when we tried to check `SAFPath(treeUri,1-segment).startsWith(SAFPath(treeUri,0-segments))`. Closes #1100
d4rken
added a commit
that referenced
this pull request
Apr 2, 2024
…age Access Framework filters work with prefix free paths, i.e. they don't care about the specific "sdcard name". #1059 removed the overlap when passing scanned paths to filters, so filters get more path information. Before filters worked with "/sdcard/nextcloud/folderA" -> "folderA" After filters worked with "/sdcard/nextcloud/folderA" -> "nextcloud/folderA" This worked for `LocalPath` but caused a bug with `SAFPath` because paths here are split into a `treeUri` and segments. The path logic failed when we tried to check `SAFPath(treeUri,1-segment).startsWith(SAFPath(treeUri,0-segments))`. Closes #1100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent SystemCleaner's "Linux Files" filter from picking up the default trash folder on Samsung devices.
Support app specific matching of files in the system's recycle bin folder on Samsung devices
e.g.:
/sdcard/Android/.Trash/<gallery/myfiles etc.>/<trash files>Closes #1057