Dashboard: Fix One-Tap-Mode sometimes not executing deletion task - #1103
Merged
Conversation
One-Tap-Mode was tied to the viewmodel lifecycle and a combination of the default scan-task and delete-task, if the viewmodel gets collected (e.g. due to ACS opening system settings over SD Maids main UI, than the coroutine that would have launched the follow up deletion task, is cancelled. The scan task still continues because after a task is launched, it is tied to the global app scope. So let's fix this by just creating a special One-Click-Task that will internally perform scan + delete.
d4rken
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-Tap-Mode was tied to the viewmodel lifecycle and a combination of the default scan-task and delete-task, if the viewmodel gets collected (e.g. due to ACS opening system settings over SD Maids main UI, than the coroutine that would have launched the follow up deletion task, is cancelled. The scan task still continues because after a task is launched, it is tied to the global app scope.
So let's fix this by just creating a special One-Click-Task that will internally perform scan + delete.