Skip to content

Shizuku: Don't hang on dashboard if Shizuku is not responding#1106

Merged
d4rken merged 1 commit into
mainfrom
shizuku_timeout
Apr 2, 2024
Merged

Shizuku: Don't hang on dashboard if Shizuku is not responding#1106
d4rken merged 1 commit into
mainfrom
shizuku_timeout

Conversation

@d4rken
Copy link
Copy Markdown
Member

@d4rken d4rken commented Mar 31, 2024

If we hang at the Shizuku check (most likely during service binding), then timeout after 6 seconds and assume useShizuku=null. null so the setup is shown again in any case.
6 seconds seems long but this is an edge-case normally it should respond with either success or failure, can't identify why it sometimes gets stuck, doesn't seem to be caused by SD Maid though.

Closes #1079

If we hang at the Shizuku check (most likely during service binding), then timeout after 6 seconds and assume `useShizuku=null`.
`null` so the setup is shown again in any case.
6 seconds seems long but this is an edge-case normally it should respond with either success or failure, can't identify why it sometimes gets stuck, doesn't seem to be caused by SD Maid though.
@d4rken d4rken added bug Something isn't working as expected enhancement New feature, request, improvement or optimization ADB ADB/Shizuku related labels Mar 31, 2024
@d4rken d4rken merged commit d7325c5 into main Apr 2, 2024
@d4rken d4rken deleted the shizuku_timeout branch April 2, 2024 12:20
@MarkyMarkDE
Copy link
Copy Markdown

MarkyMarkDE commented Apr 3, 2024

It seems we have a bug now.
You can select whatever you want, SDMaid don't save here anything, the radio will unselect after short time, or is this the right behavior?

On AndroidTV you get after update and open SDMaid the info, that the configuration is incomplete but SDMaid saves nothing, so you must hide this info message

@erfirya
Copy link
Copy Markdown

erfirya commented Apr 3, 2024

I can confirm, shizuku isn't working now afrer updating to v0.23.1-beta0
IMG_20240403_123603
IMG_20240403_123619

screen-20240403-123456.mp4

@d4rken
Copy link
Copy Markdown
Member Author

d4rken commented Apr 3, 2024

Hm, the timeout seems to kick in and return useShizuku=null resetting the choice. The user choice should still be saved, but if shizuku is not reacting then the timeout will still kick in 🤔.

I'll test this on a few devices with and without Shizuku.
Probably have to revert this and go back to the drawing board 🤔

@MarkyMarkDE
Copy link
Copy Markdown

MarkyMarkDE commented Apr 3, 2024

I would no understand why my configuration should be incomplete, in all of previous versions of SDMaid I have set "don't use Shi Dingsda" as I know that I don't have it installed and configured. Why the current version don't detect my old setting for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ADB ADB/Shizuku related bug Something isn't working as expected enhancement New feature, request, improvement or optimization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hanging on dashboard if Shizuku is not working correctly

3 participants