Core IO: Improve performance and fix memory issues when reading large folders with root or shizuku - #1127
Merged
Conversation
… folders with root or shizuku Implement `Flow<LocalPath>` for inter process communication, this reduces memory pressure. Previously when walking large folders (e.g. Termux), all folder contents were gathered in memory before being send to the main process. This could lead to the root/shizuku process running out of memory. Now we stream the walked folders in chunks so that everything doesn't have to be in memory all at once. Fixes #1117
d4rken
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
Flow<LocalPath>for inter process communication, this reduces memory pressure. Previously when walking large folders (e.g. Termux), all folder contents were gathered in memory before being send to the main process. This could lead to the root/shizuku process running out of memory. Now we stream the walked folders in chunks so that everything doesn't have to be in memory all at once.Fixes #1117