Refactor Client/Host cross process exception propagation - #1236
Merged
Merged
Conversation
…a full stacktrace across the process boundary. Not super clean but just used in debug mode and I found no other way :8
d4rken
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1233 and #1234 would have been easier to debug with this.
It's not as good as I hoped for because the stacktrace doesn't propagate through the binder correctly. Serializing the trace into the exception message is hackyasf but I didn't find a better solution. If anyone finds a better way 🍻 are on me. This is only used if
isDebug==trueso I think we can live with the hacky solution.