AppCleaner: Fix scan aborting on read errors with root- or shizuku-level access#1321
Merged
Conversation
…vel access While it was a nice idea to reconstruct the actual exceptions, this falls short for exception that don't have the default `String` constructor, e.g. `ReadException` or any `PathException`. Instead we throw a new `WrappedIPCException` that should be easily searchable, and still offer the original message and a somewhat accurate stacktrace.
d4rken
added
bug
Member
Author
|
Fixes #1319 |
d4rken
marked this pull request as draft
July 17, 2024 00:31
We used the wrong class name :'(
…IPC Modules can reconstruct the exception via reflection when propagating it.
d4rken
marked this pull request as ready for review
July 17, 2024 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to ensure that the exception we are trying to reconstruct has
constructor(String).