AppCleaner: Improve dynamic storage entry label detection#1336
Merged
Conversation
Improve `OnTheFlyLabler` by also manually calculating the formatted size value. On a VIVO device with Android 14 (`vivo/PD2366/PD2366:14/UP1A.231005.007_MOD1/compiler07161632:user/release-keys`), the `formatFileSize` was the same as the `formatShortFileSize` despite the system showing a non "short" value. The crawler showed that the storage entry looks like this ``` 2024-07-30T08:08:44.858Z V/SDMSE:Automation:Crawler: crawl():------------12: className=android.widget.TextView, text='Storage', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/title, pkgName=com.android.settings, identity=6377116 2024-07-30T08:08:44.858Z V/SDMSE:Automation:Crawler: crawl():------------12: className=android.widget.TextView, text='677,53 MB used in internal storage', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/summary, pkgName=com.android.settings, identity=20c7631 ``` but the `OnTheFlyLabler` only provided `678 MB` and not the `677,53 MB`.
d4rken
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
OnTheFlyLablerby also manually calculating the formatted size value. On a VIVO device with Android 14 (vivo/PD2366/PD2366:14/UP1A.231005.007_MOD1/compiler07161632:user/release-keys), theformatFileSizewas the same as theformatShortFileSizedespite the system showing a non "short" value.The crawler showed that the storage entry looks like this
but the
OnTheFlyLableronly provided678 MBand not the677,53 MB.