Shizuku: Improve initialization and start-up behavior - #1345
Merged
Merged
Conversation
d4rken
added
enhancement
d4rken
added a commit
that referenced
this pull request
Aug 8, 2024
Fix services being destroyed before all data has been transferred Similar to `LocalGateway.read(...): Source` where we need to keep the source alive until consumed, we need to do the same when returning a `Flow`. It's up to the caller on when it's consumed. Likely caused by #1345 Previously we had a constant lease on the Shizuku service resource so this never surfaced: https://github.com/d4rken-org/sdmaid-se/pull/1345/files#diff-3105723dbd44154e23041c05d9496670e61e15cbdcd00ea73c99d1984f577f76R135 Root will have the same issue as that changed in #1346 This fixes #1358
d4rken
added a commit
that referenced
this pull request
Aug 8, 2024
Fix services being destroyed before all data has been transferred Similar to `LocalGateway.read(...): Source` where we need to keep the source alive until consumed, we need to do the same when returning a `Flow`. It's up to the caller on when it's consumed. Likely caused by #1345 Previously we had a constant lease on the Shizuku service resource so this never surfaced: https://github.com/d4rken-org/sdmaid-se/pull/1345/files#diff-3105723dbd44154e23041c05d9496670e61e15cbdcd00ea73c99d1984f577f76R135 Root will have the same issue as that changed in #1346 This fixes #1358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.