Skip to content

AppCleaner: Fix accessibility based cache deletion on OnePlus devices with Android 14/15 - #1491

Merged
d4rken merged 1 commit into
mainfrom
appcleaner-oneplus-acs-api34
Dec 3, 2024
Merged

AppCleaner: Fix accessibility based cache deletion on OnePlus devices with Android 14/15#1491
d4rken merged 1 commit into
mainfrom
appcleaner-oneplus-acs-api34

Conversation

@d4rken

@d4rken d4rken commented Dec 3, 2024

Copy link
Copy Markdown
Member

@d4rken d4rken added bug Something isn't working as expected c: AppCleaner api: 34 A14 (Upside Down Cake) Device specific A device specific issue or behavior. api: 35 A15 (Vanilla Ice Cream) labels Dec 3, 2024
@d4rken
d4rken merged commit 820aef3 into main Dec 3, 2024
@d4rken
d4rken deleted the appcleaner-oneplus-acs-api34 branch December 3, 2024 12:31
@d4rken d4rken mentioned this pull request Dec 10, 2024
@MisakaSakura

Copy link
Copy Markdown

This problem still exists if you update it directly, you can't call the system's accessibility service to complete the application cleanup, and the solution is to reinstall the sd_maid in the system's built-in "file" app, but I want to mention one thing, this use of accessibility to replace the manual clearing of cache The operation is too inefficient and occupies the user's mobile phone. Why can't users who have been granted root privileges or Shizuku permission directly use advanced privileges to delete the cache as before?

In fact, SE is not currently more efficient than the old version.

@d4rken

d4rken commented Dec 13, 2024

Copy link
Copy Markdown
Member Author

This problem still exists if you update it directly, you can't call the system's accessibility service to complete the application cleanup, and the solution is to reinstall the sd_maid in the system's built-in "file" app

Why post here? That's unrelated to this OnePlus specific issue. It's a security restriction on newer Android versions. There is a workaround without built-in file app, see: https://github.com/d4rken-org/sdmaid-se/wiki/Setup#acs-appops-restrictions

but I want to mention one thing, this use of accessibility to replace the manual clearing of cache The operation is too inefficient and occupies the user's mobile phone. Why can't users who have been granted root privileges or Shizuku permission directly use advanced privileges to delete the cache as before?

If root is working correctly, then the accessibility service will not be used. If only Shizuku is available, then you need to exclude system apps, and not exclude any normal apps, then it should also work without ACS.

In fact, SE is not currently more efficient than the old version.

Debatable, in terms of speed, for some cases yes, for rare cases not. In terms of compatibility and thoroughness, it is much better than SDM1.

@MisakaSakura

Copy link
Copy Markdown

This problem still exists if you update it directly, you can't call the system's accessibility service to complete the application cleanup, and the solution is to reinstall the sd_maid in the system's built-in "file" app

Why post here? That's unrelated to this OnePlus specific issue. It's a security restriction on newer Android versions. There is a workaround without built-in file app, see: https://github.com/d4rken-org/sdmaid-se/wiki/Setup#acs-appops-restrictions

but I want to mention one thing, this use of accessibility to replace the manual clearing of cache The operation is too inefficient and occupies the user's mobile phone. Why can't users who have been granted root privileges or Shizuku permission directly use advanced privileges to delete the cache as before?

If root is working correctly, then the accessibility service will not be used. If only Shizuku is available, then you need to exclude system apps, and not exclude any normal apps, then it should also work without ACS.

In fact, SE is not currently more efficient than the old version.

Debatable, in terms of speed, for some cases yes, for rare cases not. In terms of compatibility and thoroughness, it is much better than SDM1.

Sorry, I'm commenting here because I happened to see a changelog mentioning an accessibility issue with fixing cache cleaning on OnePlus devices.
In addition, I used Magisk to complete the cleanup with Shizuku before, but there was no call to the accessibility service, so it may be that SE used Magisk SU with higher permissions first, right?
Now the root provides the authorization of the kernelsu, and the application does not actively ask the kernelsu for authorization, so the default root permission is denied;
Maybe SD Maid SE can provide two options for users to choose between using root and using Shizuku in the settings, just like some apps that use Shizuku permissions

@d4rken

d4rken commented Dec 13, 2024

Copy link
Copy Markdown
Member Author

Now the root provides the authorization of the kernelsu, and the application does not actively ask the kernelsu for authorization, so the default root permission is denied;

Hm 🤔 SD Maid just calls su in the terminal to launch a shell with root permission. It doesn't really matter whether that is provided by Magisk or KernelSU. If you want to further debug this, please open a new ticket and provide debug logs of completing the root setup.

Maybe SD Maid SE can provide two options for users to choose between using root and using Shizuku in the settings, just like some apps that use Shizuku permissions

SD Maid will always use the best available access method. That's why it's good to complete as many setup items as possible.

In addition, I used Magisk to complete the cleanup with Shizuku before, but there was no call to the accessibility service, so it may be that SE used Magisk SU with higher permissions first, right?

I don't know what you mean, "used Magisk to complete the cleanup with Shizuku"? What does that mean.

In any case, I don't like guessing around. If there is a concrete issue, please open a ticket and provide reproduction steps and a debug log, then I'll look into it.

Currently we are talking about many different topics in chaos without a clear path forward.

@MisakaSakura

Copy link
Copy Markdown

Now the root provides the authorization of the kernelsu, and the application does not actively ask the kernelsu for authorization, so the default root permission is denied;

Hm 🤔 SD Maid just calls su in the terminal to launch a shell with root permission. It doesn't really matter whether that is provided by Magisk or KernelSU. If you want to further debug this, please open a new ticket and provide debug logs of completing the root setup.

Maybe SD Maid SE can provide two options for users to choose between using root and using Shizuku in the settings, just like some apps that use Shizuku permissions

SD Maid will always use the best available access method. That's why it's good to complete as many setup items as possible.

In addition, I used Magisk to complete the cleanup with Shizuku before, but there was no call to the accessibility service, so it may be that SE used Magisk SU with higher permissions first, right?

I don't know what you mean, "used Magisk to complete the cleanup with Shizuku"? What does that mean.

In any case, I don't like guessing around. If there is a concrete issue, please open a ticket and provide reproduction steps and a debug log, then I'll look into it.

Currently we are talking about many different topics in chaos without a clear path forward.

I mean sd maid se can directly authorize root through magisk or kernelsu, or let the latter two give shizuku permission to start and then shizuku authorize sd maid, for magisk, because in the first place sd maid
SE will ask for root permissions, so SD Maid SE is actually using root privileges instead of Shizuku's authorization;
As for kernelsu, because the application does not actively ask for root permissions, but I use kernelsu to boot shizuku (so that shizuku can be started without USB debugging), so under this method, sd maid se is actually authorized by shizuku;
This is not a problem with sd maid se, but a lack of understanding of the difference between the authorization of the two root methods in my execution process.

@d4rken

d4rken commented Dec 13, 2024

Copy link
Copy Markdown
Member Author

I still don't understand what you are are trying to tell me.
I have not used KernelSu yet.
If you want me to change something in SD Maid, please open a new ticket. Thanks

@d4rken-org d4rken-org locked as off-topic and limited conversation to collaborators Dec 13, 2024
@d4rken d4rken added the ROM: OxygenOS OnePlus before ColorOS label May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: 34 A14 (Upside Down Cake) api: 35 A15 (Vanilla Ice Cream) bug Something isn't working as expected c: AppCleaner Device specific A device specific issue or behavior. ROM: OxygenOS OnePlus before ColorOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants