Refactor: Add AutomationService.Snapshot and debug logging - #1784
Merged
Conversation
Introduce a `Snapshot` data class to wrap `AccessibilityEvent`s within the `AutomationService`. This `Snapshot` now includes a unique ID. Modify the event flow exposed by `AutomationHost` to emit `Snapshot`s instead of raw `AccessibilityEvent`s. Update usages in `HyperOsSpecs`, `SpecGeneratorExtensions`, and `DebugTaskModule` to extract the event from the `Snapshot`. Implement debug logging for screen snapshots in `AutomationService`. This includes logging the snapshot ID, the event, and the crawled node hierarchy, with a timeout to prevent blocking. This logging is enabled only in debug builds.
d4rken
added
Automation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
Snapshotdata class to wrapAccessibilityEvents within theAutomationService. ThisSnapshotnow includes a unique ID.Modify the event flow exposed by
AutomationHostto emitSnapshots instead of rawAccessibilityEvents. Update usages inHyperOsSpecs,SpecGeneratorExtensions, andDebugTaskModuleto extract the event from theSnapshot.Implement debug logging for screen snapshots in
AutomationService. This includes logging the snapshot ID, the event, and the crawled node hierarchy, with a timeout to prevent blocking. This logging is enabled only in debug builds.