Storage Analyzer: Improve UX for exclusion creation and selection - #1791
Merged
Conversation
d4rken
added
enhancement
- Always enable selection for all items, regardless of accessibility. - Disable "Delete" and "Create Filter" actions in the CAB menu if any selected item is inaccessible. - When a single item is excluded, the "View" action in the Snackbar now directly opens the created exclusion instead of navigating to the general exclusions list. - Refactored event handling for exclusion creation to pass the affected content items, enabling more specific UI updates. Implements #1643
d4rken
force-pushed
the
analyzer-top-level-exclusions
branch
from
May 26, 2025 04:05
0fe8828 to
924e0cc
Compare
Refactored `keepResourceHoldersAlive` and `keepResourcesAlive` to accept varargs instead of collections for `SharedResource` and `HasSharedResource` respectively. This simplifies callsites by removing the need to create explicit collections. Additionally, introduced a new `Collection<T>.useRes` extension function for more concise handling of multiple `SharedResource` instances within a block.
d4rken
force-pushed
the
analyzer-top-level-exclusions
branch
from
May 27, 2025 18:22
ab39c0c to
aa5ad2e
Compare
d4rken
marked this pull request as ready for review
May 27, 2025 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1643
Draft: Check #1644 and #1645