Automation: Unify exception handling in AppControl and AppCleaner#1808
Merged
Conversation
This change refactors the exception handling logic in `AppControlAutomation.kt` and `ClearCacheModule.kt` to use a `when` statement for better readability and consistency. Key changes: - Replaced multiple `catch` blocks with a single `catch (e: Exception)` block. - Used a `when` statement within the `catch` block to handle different exception types. - Ensured consistent logging and error reporting across both modules. - Maintained existing logic for specific exceptions like `AutomationTimeoutException`, `UserCancelledAutomationException`, and `PlanAbortException`. - Re-throw unhandled critical exceptions like `InvalidSystemStateException`, `AutomationOverlayException`, and `UnsupportedOperationException` after logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors the exception handling logic in
AppControlAutomation.ktandClearCacheModule.ktto use awhenstatement for better readability and consistency.Key changes:
catchblocks with a singlecatch (e: Exception)block.whenstatement within thecatchblock to handle different exception types.AutomationTimeoutException,UserCancelledAutomationException, andPlanAbortException.InvalidSystemStateException,AutomationOverlayException, andUnsupportedOperationExceptionafter logging.