AppCleaner: Correctly update inaccessible item count after deletion - #1809
Merged
Conversation
The `itemCount` for inaccessible items was incorrectly hardcoded to `1`, which would be wrong if multiple files contributed to the inaccessible size. This change removes the incorrect `itemCount` update, ensuring the `totalSize` and `publicSize` are correctly adjusted after deleting inaccessible files.
d4rken
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
itemCountfor inaccessible items was incorrectly hardcoded to1, which would be wrong if multiple files contributed to the inaccessible size. This change removes the incorrectitemCountupdate, ensuring thetotalSizeandpublicSizeare correctly adjusted after deleting inaccessible files.