AppCleaner: Simplify MIUI automation logic - #1818
Merged
Merged
Conversation
This commit refactors the MIUI automation specification to simplify node selection and improve robustness across different MIUI versions. Previously, the automation differentiated between MIUI versions (10/11 vs 12+) to determine if a node was a `TextView` or a `Button` and whether to find a clickable parent. This has been simplified: - The automation now primarily looks for nodes with text matching "Clear data" or "Clear cache". - If the found node is not clickable, it will attempt to find a clickable parent. - The explicit version check (`isMiui12Plus`) has been removed. Fixes #1814
d4rken
added
c: AppCleaner
Automation
Pj863
approved these changes
Jun 4, 2025
Pj863
left a comment
Pj863
left a comment
There was a problem hiding this comment.
I really love this app keep up the great work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the MIUI automation specification to simplify node selection and improve robustness across different MIUI versions.
Previously, the automation differentiated between MIUI versions (10/11 vs 12+) to determine if a node was a
TextViewor aButtonand whether to find a clickable parent.This has been simplified:
isMiui12Plus) has been removed.Fixes #1814