Skip to content

General: Fix minimum size input in Korean and other locales - #2051

Merged
d4rken merged 1 commit into
mainfrom
korean-size-parser-1813
Dec 15, 2025
Merged

d4rken merged 1 commit into
mainfrom
korean-size-parser-1813

Conversation

@d4rken

@d4rken d4rken commented Dec 15, 2025

Copy link
Copy Markdown
Member

When extracting size units from Formatter.formatShortFileSize(), the code split by whitespace which failed for locales where no space exists between number and unit (e.g., "1KB" instead of "1 KB").

Changed to use regex extraction of trailing letters to reliably get the unit regardless of locale formatting.

Added unit tests for English, Korean, Russian (Cyrillic), and Arabic (Arabic-Indic numerals) locales.

Fixes #1813

When extracting size units from Formatter.formatShortFileSize(), the code
split by whitespace which failed for locales where no space exists between
number and unit (e.g., "1KB" instead of "1 KB").

Changed to use regex extraction of trailing letters to reliably get the
unit regardless of locale formatting.

Added unit tests for English, Korean, Russian (Cyrillic), and Arabic
(Arabic-Indic numerals) locales.

Fixes #1813
@d4rken d4rken added bug Something isn't working as expected General UI/UX User Interface/Experience labels Dec 15, 2025
@d4rken
d4rken merged commit eab19b6 into main Dec 15, 2025
13 checks passed
@d4rken
d4rken deleted the korean-size-parser-1813 branch December 15, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected General UI/UX User Interface/Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minimum size set error

1 participant