Skip to content

IO: Fix LocalPath.exists() check on Android 12+ for Android/data.#467

Merged
d4rken merged 2 commits into
mainfrom
io_localgateway_exists_check
Jul 3, 2023
Merged

IO: Fix LocalPath.exists() check on Android 12+ for Android/data.#467
d4rken merged 2 commits into
mainfrom
io_localgateway_exists_check

Conversation

@d4rken

@d4rken d4rken commented Jul 2, 2023

Copy link
Copy Markdown
Member

LocalPath.exists() returned wrong results for access mode=NORMAL on Android 12 for Android/data due to evaluating the fallback clause and thinking the storage root (e.g. /storage/emulated/0 is a good indicator whether the File.exists() result is trust worthy. This just isn't the case anymore on Android 12+.

See #315, potential fix.

d4rken added 2 commits July 2, 2023 22:08
LocalPath.exists() returned wrong results for access mode=NORMAL on Android 12 for Android/data due to evaluating the fallback clause and thinking the storage root (e.g. `/storage/emulated/0` is a good indicator whether the `File.exists()` result is trust worthy. This just isn't the case anymore on Android 12+.

See #315, potential fix.
@d4rken d4rken added bug Something isn't working as expected c: IO SAF/Normal/Root access ADB ADB/Shizuku related labels Jul 2, 2023
@d4rken d4rken merged commit 5268351 into main Jul 3, 2023
@d4rken d4rken deleted the io_localgateway_exists_check branch July 3, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ADB ADB/Shizuku related bug Something isn't working as expected c: IO SAF/Normal/Root access

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant