Repository navigation
Analyzer: Improve app scan performance - #578
Merged
Merged
Conversation
…TYPE if available
…UTO` as we could otherwise fail. Scenario: User has SAF access only to storage, and we try to check the existence of "/sdcard/Android/media" which then fails because there is no matching access mode.
… theoretically be anything (i.e. a SAFPath too).
Refactor app scanning code into an extra class and cache values that are the same for all apps we check during a scan.
d4rken
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache more values and reduce duplicate checks that only need to be executed once per storage scan for all apps.