Scheduler: Add option to skip when not charging - #604
Merged
Conversation
Closes d4rken-org#564. Please note that this commit is still untested (I have to set up the Android SDK).
Default to disabled and fix settings icon appearance.
Removed extraneous spacing and EOL-at-EOF.
d4rken
approved these changes
Sep 2, 2023
d4rken
left a comment
d4rken
left a comment
Member
There was a problem hiding this comment.
Sorry mate, that wasn't nice of me to keep you waiting for so long
I assume you tested the feature on your device?
d4rken
enabled auto-merge (rebase)
September 2, 2023 19:19
d4rken
disabled auto-merge
September 2, 2023 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a scheduler setting for skipping scheduled tasks when the device is not charging. The option is added to the "Scheduler" submenu in the settings, right under "Skip on low battery", using the icon
.The check for this setting is done immediately after that for skipping on low battery.
Closes #564.