AppCleaner: If the lock screen becomes active, hide the overlay until the lockscreen is dismissed - #685
Merged
Merged
Conversation
…interaction Some users have reported trouble with stopping SD Maid when the lock-in screen became active.
…interaction Some users have reported trouble with stopping SD Maid when the lock-in screen became active.
d4rken
added
enhancement
d4rken
added a commit
that referenced
this pull request
Oct 13, 2023
Operations that use the accessibility service may obstruct the user. In some cases the lockscreen prevented the user from canceling. So #685 disabled the overlay if the screen is unavailable, e.g. the lockscreen is active. This change goes a step further. The overlay is still hidden if the screen becomes unavailable, but we will also throw a special Exception that should propagate up the stack and cancel the whole operation. So to stop the automation, turning off the screen is enough. The automation itself keeps the screen from timing-out, so this should only happen if the user manually presses the power button. Also see #692. Closes #686 A "pause" option would be inappropriate here, screen becoming unavailable is an exceptional state.
d4rken
added a commit
that referenced
this pull request
Oct 13, 2023
Operations that use the accessibility service may obstruct the user. In some cases the lockscreen prevented the user from canceling. So #685 disabled the overlay if the screen is unavailable, e.g. the lockscreen is active. This change goes a step further. The overlay is still hidden if the screen becomes unavailable, but we will also throw a special Exception that should propagate up the stack and cancel the whole operation. So to stop the automation, turning off the screen is enough. The automation itself keeps the screen from timing-out, so this should only happen if the user manually presses the power button. Also see #692. Closes #686 A "pause" option would be inappropriate here, screen becoming unavailable is an exceptional state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue that some users were not able to dismiss their lockscreen while the overlay was active, but they were also not able to dismiss the overlay.