Root/Shizuku: Fix SD Maid crashing on when activating Root or Shizuku#725
Merged
Conversation
As guessed, was an R8 issue. Before the AGP update (i.e. on 8.0.2) the DESCRIPTOR field was implicitly kept. After moving to AGP 8.1.2 and fixing the reflection access (#705) works, but R8 will remove the field. So this PR adds rules to keep the `DESCRIPTOR` field for Root and Shizuku. Fixes #721 Fixes #722
d4rken
added
bug
Member
Author
|
Without the rules, both Shizuku and Root: With the rules, Root: result = {Field[10]@32895}
0 = {Field@32896} "public static final int android.os.IBinder.DUMP_TRANSACTION"
1 = {Field@32897} "public static final int android.os.IBinder.FIRST_CALL_TRANSACTION"
2 = {Field@32898} "public static final int android.os.IBinder.FLAG_ONEWAY"
3 = {Field@32899} "public static final int android.os.IBinder.INTERFACE_TRANSACTION"
4 = {Field@32900} "public static final int android.os.IBinder.ISSYSTEMSERVER_TRANSACTION"
5 = {Field@32901} "public static final int android.os.IBinder.LAST_CALL_TRANSACTION"
6 = {Field@32902} "public static final int android.os.IBinder.LIKE_TRANSACTION"
7 = {Field@32903} "public static final int android.os.IBinder.PING_TRANSACTION"
8 = {Field@32904} "public static final int android.os.IBinder.TWEET_TRANSACTION"
9 = {Field@32905} "public static final java.lang.String eu.darken.sdmse.common.root.service.RootServiceConnection.DESCRIPTOR"With the rules, Shizuku: result = {Field[10]@33525}
0 = {Field@33526} "public static final int android.os.IBinder.DUMP_TRANSACTION"
1 = {Field@33527} "public static final int android.os.IBinder.FIRST_CALL_TRANSACTION"
2 = {Field@33528} "public static final int android.os.IBinder.FLAG_ONEWAY"
3 = {Field@33529} "public static final int android.os.IBinder.INTERFACE_TRANSACTION"
4 = {Field@33530} "public static final int android.os.IBinder.ISSYSTEMSERVER_TRANSACTION"
5 = {Field@33531} "public static final int android.os.IBinder.LAST_CALL_TRANSACTION"
6 = {Field@33532} "public static final int android.os.IBinder.LIKE_TRANSACTION"
7 = {Field@33533} "public static final int android.os.IBinder.PING_TRANSACTION"
8 = {Field@33534} "public static final int android.os.IBinder.TWEET_TRANSACTION"
9 = {Field@33535} "public static final java.lang.String eu.darken.sdmse.common.shizuku.ShizukuServiceConnection.DESCRIPTOR" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As guessed, was an R8 issue.
Before the AGP update (i.e. on 8.0.2) the DESCRIPTOR field was implicitly kept. After moving to AGP 8.1.2 and fixing the reflection access (#705) works, but R8 will remove the field.
So this PR adds rules to keep the
DESCRIPTORfield for Root and Shizuku.Fixes #721
Fixes #722