SystemCleaner: If the ANR filter fails to initialize correctly, fail silently - #925
Merged
Merged
Conversation
d4rken
added
enhancement
…silently The error dialog doesn't help the user and operations can just continue and this filter just doesn't match. Easier for the user. So let's not pop an error dialog and just log a warning.
d4rken
force-pushed
the
systemcleaner_anr_silent_fail
branch
from
January 16, 2024 14:42
cc6678b to
d8df79f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error dialog doesn't help the user and operations can just continue and this filter just doesn't match. Easier for the user.
So let's not pop an error dialog and just log a warning.