Skip to content

AppCleaner: Support for HONOR devices with Android 13+#926

Merged
d4rken merged 2 commits into
mainfrom
appcleaner_acs_honor5pro
Jan 17, 2024
Merged

AppCleaner: Support for HONOR devices with Android 13+#926
d4rken merged 2 commits into
mainfrom
appcleaner_acs_honor5pro

Conversation

@d4rken

@d4rken d4rken commented Jan 16, 2024

Copy link
Copy Markdown
Member

Currently AppCleaner treats HONOR devices/ROMs as ASOP ROMs and uses the matching there.

I've got one report now that could indicate that this no longer works with Android 13+ and that we might need special handling for the ROM.

@d4rken d4rken added enhancement New feature, request, improvement or optimization api: 33 A13 (Tiramisu) c: AppCleaner Automation Accessibility service related (ACS) Device specific A device specific issue or behavior. labels Jan 16, 2024
@d4rken

d4rken commented Jan 16, 2024

Copy link
Copy Markdown
Member Author

So this device:

2023-12-27T09:22:19.999Z  I/SDMSE:Debug:Log:Recorder:Module: APILEVEL: 33
2023-12-27T09:22:19.999Z  I/SDMSE:Debug:Log:Recorder:Module: Build.FINGERPRINT: HONOR/PGT-N19EEA/HNPGT:13/HONORPGT-N49/7.1.0.176C431E3R2P3:user/release-keys
2023-12-27T09:22:20Z  I/SDMSE:Debug:Log:Recorder:Module: Build.MANUFACTOR: HONOR
2023-12-27T09:22:20Z  I/SDMSE:Debug:Log:Recorder:Module: Build.BRAND: HONOR
2023-12-27T09:22:20Z  I/SDMSE:Debug:Log:Recorder:Module: Build.PRODUCT: PGT-N19EEA
2023-12-27T09:22:20Z  I/SDMSE:Debug:Log:Recorder:Module: App: eu.darken.sdmse - 0.18.2-beta0 (1802000) 
2023-12-27T09:22:20Z  I/SDMSE:Debug:Log:Recorder:Module: Build: GPLAY-BETA

Has this settings screen

2023-12-27T09:22:33.593Z  V/SDMSE:Automation:Crawler: Checking current nodes:
2023-12-27T09:22:33.594Z  V/SDMSE:Automation:Crawler: crawl():0: className=android.widget.FrameLayout, text='null', isClickable=false, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.594Z  V/SDMSE:Automation:Crawler: crawl():-1: className=androidx.drawerlayout.widget.DrawerLayout, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/drawer_layout, pkgName=com.android.settings
2023-12-27T09:22:33.594Z  V/SDMSE:Automation:Crawler: crawl():--2: className=android.widget.LinearLayout, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/content_parent, pkgName=com.android.settings
2023-12-27T09:22:33.595Z  V/SDMSE:Automation:Crawler: crawl():---3: className=android.widget.ImageButton, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.595Z  V/SDMSE:Automation:Crawler: crawl():---3: className=android.widget.TextView, text='Informacje o aplikacji', isClickable=false, isEnabled=true, viewIdResourceName=android:id/action_bar_title, pkgName=com.android.settings
2023-12-27T09:22:33.595Z  V/SDMSE:Automation:Crawler: crawl():---3: className=androidx.recyclerview.widget.RecyclerView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/list, pkgName=com.android.settings
2023-12-27T09:22:33.597Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='Brave', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.597Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=android:id/summary, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='Wersja 1.61.109', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/widget_text1, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/widget_text2, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/widget_text1, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/widget_text2, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/widget_text1, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/widget_text2, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/widget_text1, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.TextView, text='null', isClickable=false, isEnabled=true, viewIdResourceName=com.android.settings:id/widget_text2, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.Button, text='ODINSTALUJ', isClickable=true, isEnabled=true, viewIdResourceName=com.android.settings:id/left_button, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.Button, text='ZATRZYMAJ', isClickable=true, isEnabled=true, viewIdResourceName=com.android.settings:id/right_button, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=false, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Powiadomienia', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.598Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.599Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Uprawnienia', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.599Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.599Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Użycie danych', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.599Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=false, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.599Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.599Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Pamięć', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.600Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='W użyciu 0,93 GB (pamięć wewnętrzna)', isClickable=false, isEnabled=true, viewIdResourceName=android:id/summary, pkgName=com.android.settings
2023-12-27T09:22:33.600Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.600Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Pamięć', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.600Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Średnie wykorzystanie pamięci w ciągu ostatnich 3 h: 5,5 KB', isClickable=false, isEnabled=true, viewIdResourceName=android:id/summary, pkgName=com.android.settings
2023-12-27T09:22:33.600Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.600Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Szczegóły dotyczące zużycia energii', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.600Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.601Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Otwórz domyślnie', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.601Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Brak ustawień domyślnych', isClickable=false, isEnabled=true, viewIdResourceName=android:id/summary, pkgName=com.android.settings
2023-12-27T09:22:33.601Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=false, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.601Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='NIEUŻYWANE APLIKACJE', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.601Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.602Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Usuń uprawnienia i zwolnij miejsce', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.602Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.Switch, text='null', isClickable=true, isEnabled=true, viewIdResourceName=android:id/switch_widget, pkgName=com.android.settings
2023-12-27T09:22:33.602Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=false, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.602Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='SKLEP', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.602Z  V/SDMSE:Automation:Crawler: crawl():----4: className=android.widget.LinearLayout, text='null', isClickable=true, isEnabled=true, viewIdResourceName=null, pkgName=com.android.settings
2023-12-27T09:22:33.603Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Dane aplikacji', isClickable=false, isEnabled=true, viewIdResourceName=android:id/title, pkgName=com.android.settings
2023-12-27T09:22:33.603Z  V/SDMSE:Automation:Crawler: crawl():-----5: className=android.widget.TextView, text='Aplikacja zainstalowana z: Sklep Google Play', isClickable=false, isEnabled=true, viewIdResourceName=android:id/summary, pkgName=com.android.settings
2023-12-27T09:22:33.610Z  V/SDMSE:Automation:Crawler: Target node not found

The keyword SD Maid is looking for is Pamięć, is not among the AOSP spec provided keywords:

Spec(parent=SDMSE:AppCleaner:Automation:AOSP:Specs, label=Find & click 'Storage' (targets=[Pamięć i pamięć podręczna, Pamięć wewnętrzna i podręczna, Pamięć wewnętrzna]))

@d4rken

d4rken commented Jan 16, 2024

Copy link
Copy Markdown
Member Author

I could just add that to pl for AOSP, but not if the whole HONOR ROM needs extra treatment...

@d4rken d4rken marked this pull request as ready for review January 17, 2024 10:34
@d4rken d4rken merged commit 524d755 into main Jan 17, 2024
@d4rken d4rken deleted the appcleaner_acs_honor5pro branch January 17, 2024 10:34
@d4rken d4rken added the ROM: MagicOS Honor devices. label May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: 33 A13 (Tiramisu) Automation Accessibility service related (ACS) c: AppCleaner Device specific A device specific issue or behavior. enhancement New feature, request, improvement or optimization ROM: MagicOS Honor devices.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant