New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include folders on the root of the sdcard #1067

Closed
d4rken opened this Issue Aug 16, 2017 · 1 comment

Comments

1 participant
@d4rken
Owner

d4rken commented Aug 16, 2017

We currently don't include databases in custom app dirs in the root of public storage. While databases there are rare it's still possible. We don't want to scan everything though for performance reason.

How many levels do we search though.

/storage/emulated/0/Locus/data/database/waypoints.db

is currently not found, to find out though we have to search 3 levels deep, this could increase scan time quite a lot. Limiting search to all dirs with known owners should could it down. Also need to exclude dirs owner by android and dirs flagged common.

  • Include public storage roots
  • Ensure we don't search nested public storages ( /sdcard/externalSD) twice
  • Only known owners
  • Exclude owner system
  • 3 levels deep
  • Exclude with flag common
@d4rken

This comment has been minimized.

Owner

d4rken commented Sep 21, 2017

Not putting any additional restrictions on the searchpath on this for now as it would conflict with the option that allows users to modify and add search pathes via settings.

@d4rken d4rken closed this Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment