Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan results from the UninstallWatcher are not consistently displayed #1281

Closed
d4rken opened this issue Oct 29, 2017 · 1 comment
Closed

Scan results from the UninstallWatcher are not consistently displayed #1281

d4rken opened this issue Oct 29, 2017 · 1 comment
Milestone

Comments

@d4rken
Copy link
Owner

@d4rken d4rken commented Oct 29, 2017

If the UninstallWatcher triggers and finds results there is an inconsistence between the results displayed in the popup and the main app.

  • The QuickAccess entry can show a higher amount of corpses than the previous uninstall watcher results because the entry takes it's information from the scan progress information which are not filtered. The uninstall watcher filters out anything unrelated to the app uninstall that triggered the event.
  • Because the uninstall watcher scan triggers a different task than the default scan from the main UI, the worker still has isNew=true which causes the intro UI to show instead of the results.
@d4rken d4rken added this to the v4.8.4 milestone Oct 29, 2017
@d4rken
Copy link
Owner Author

@d4rken d4rken commented Oct 29, 2017

Best course of action is probably to remove the extra uninstallwatcher task and enhance the default scan task to take filter arguments, that way both events take the same route through the code and we prevent future issues like this.

@d4rken d4rken closed this Oct 30, 2017
Repository owner deleted a comment from carlossnowden Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant