New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict System Cleaner and Exceptions #1290

Closed
GabrielMGitHub opened this Issue Nov 2, 2017 · 5 comments

Comments

2 participants
@GabrielMGitHub

GabrielMGitHub commented Nov 2, 2017

Even having nothing to be clean is showing amount and size of files that need to be deleted erroneously. This error is happening because the files are protected in exceptions. Should not show these values, it should show 0 items.

Device: Asus Zenfone 2 Laser
Android: 6.0.1
Version SD Maid: 4.8.5

screenshot_20171102-001424
screenshot_20171102-001518
screenshot_20171102-001427
screenshot_20171102-001933

@GabrielMGitHub

This comment has been minimized.

GabrielMGitHub commented Nov 2, 2017

@21101969sanjay The version that presents this error is not the one of production, but of development. Version 4.8.5.

@d4rken d4rken added this to the Next Update milestone Nov 2, 2017

@d4rken

This comment has been minimized.

Owner

d4rken commented Nov 2, 2017

Could confirm this. Nice catch @GabrielMGitHub .

Repository owner deleted a comment from 21101969sanjay Nov 2, 2017

@d4rken

This comment has been minimized.

Owner

d4rken commented Nov 2, 2017

The issue was that there were two routines to update the scan results object, one that sets the final data and one that increases the size and file counter with every nice filtered file. Increasing the counters with every file was a remnant from an older routine to display progress information. The exclusions were still valid, it was the progress information that was buggy.

While the exclusion removed the files from the final dataset, this happened after the counters were already increased. I've fixed the overall code and removed the manual counters. When setting the filtered files to the Scantask.Result object, we can just count the items and size. So overall the code is cleaner 👍

Fix commited for the next update.

@d4rken d4rken closed this Nov 2, 2017

@GabrielMGitHub

This comment has been minimized.

GabrielMGitHub commented Nov 2, 2017

@d4rken Thank you for your work and attention.

@d4rken

This comment has been minimized.

Owner

d4rken commented Nov 2, 2017

I shouldn't have deleted your comment @21101969sanjay, I thought it was spam, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment