New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check mount matching and remount behavior on systemless root setups #2135

Open
d4rken opened this Issue Nov 20, 2018 · 4 comments

Comments

3 participants
@d4rken
Owner

d4rken commented Nov 20, 2018

@d4rken

This comment has been minimized.

Owner

d4rken commented Nov 20, 2018

On @toledofaustino85's LOS setup (see) SD Maid already correctly maps the SYSTEM storage to mountpoint /

Storage(location=SYSTEM, path=/system, userHandle=-1, flags=[PRIMARY], safUri=null, mount=Mountpoint(path=/, blockDevice=/dev/root, fileSystemType=EXT4, options=[relatime, seclabel, data=ordered, ro]))

this is due to us searching hierarchical along the path of /system and ending up at /.

So systemless / works and the default /system works. The only issue here would be the edge case where /system is a symlink and the actual mount is /system_root. Possibly on older SuperSU setups, still unconfirmed though.

My first thought would be to check whether /system is a symlink and if so, follow the link and resolve the mount of it's link target. Hm, can we read this via java's fs calls? Does the Storage class generation tool have access to a root shell? Do we need root to determine this?

Androids API offers Environment.getRootDirectory(), I wonder what that returns on such a symlinked setup...

@toledofaustino85

This comment has been minimized.

toledofaustino85 commented Nov 21, 2018

Currently we want to write something that devices whether the mount applet is usable, as quickly as possible. To do this we attempt to remount "the system partition".

Ok, I understand. With the information we have available until now I propose the following logic:

Try /system
If no error then goto :additional_checks
else
check ro.build.system_root_image
If "true" then try "/"
If no error then goto :additional_checks //false alarm, all be ok, its a "new phone"
else goto :we_have_a_problem
else goto :we_have_a_problem
endif
endif
endif

:additional_checks
try /system_root (optional and for info. purposes)

:we_have_a_problem
run panic_mode (maybe applet does not works...)

Better?

@gitVictim83

This comment has been minimized.

gitVictim83 commented Dec 3, 2018

To everyone here..a big thank you for destroying my entire life! I lost my job, lost my kids and now, im about to lose my life..i a great pleasure not hearing my side of the story before doing this to me..one of u here, knows the true story and everything happnd..and for those who dont believe me, please check out my microsoft one drive or google drive using this email..theres pictures of me with my lower lip bleeding and a tank top with also my blood on it..om already tired of my situation..and up to now, even without any txt from me, she still angry at me and prob would go to court..and even if she done lots of not really noce things to me, i still love her as well as my kids..and to wait this and her anger got even worst, i dont knw what else to do..the agony of waiting is already eating me inside out..probably, amd im sorry for saying this, that one of u or u guys might know, is doing these to her as well..as iv said, im tired, i jst want my family back thats it..i told her so many times that im really change for good..i mentiond that also to one of the gentleman here..but its been close to 10months..iv lost everything..i will not even get my retirment that was intended for our 3 kids, for their studies..and all of that were put to waste..even if how much i beg and plead..nothing..last time i brought her flowers, i begged and kneeled down in front of her..but her mood suddenly changed when someone came..and then she yelled at me saying to get out of their house..and i was crying that time..when i was abt to approached my car, i saw someone outside, a guy..waiting..but sonce it was alrwady night time and some rain, i was not able to see cleay the guys face..and there was also an instance at night, that i came to her house and would like to askd her if she would like some midnight snack, when i peeped to their exhaust fan, i saw our 3 kids and she was nowhere insight..amd it wws 2am..i would like to share everything to u, but il ran out of space here..but these are just part of my side of the story..im not askng for anyone here to believe me and do somethng..il leave evrything all up to u..like i said to my friend here, for u to listen to listen to me, il be fine and probably get my aanity back, somehow..but for u to give me an advice, iylrs a bonus for me since i would only like for u to here me out and askd for nothing but only both ur ears..and by giving me advices, would be a plus for me and will be forever thankful for that..but all of these are jst has beens..theres nothing more to save..my family is my life..and simple question will do and il answer each and everyone of u with all honesty..if u heard me aay some not so nice words, its bec i saw lots of unnc necessary things..and when i askd her, she dodnt answer, until now..i even had my share of bad words..and bec of these, some of u might have even used my parents name of initials
in some of ur codes...and we cannot take back lost time and evrythng that were gone..losing my family is the same as losing my own life...and whatever iv accommplishd in my career is bec of them..i will do anythng for them, they are the reason of my hard work..and for 2 years, i had to change the weekends to weekdays and go to ofc or to my clients..and before 2017 ended, i told her that 2018 wil be diffrnt and will make up for lost time..then these happnd..but its ok..amd for those who had no idea and didnt askd me even 1 question..its ok, and i forgve u ..but u guys have to undrstand me also..im tired of waiting for these to end..iv already lost hope..and im sure i dont feel anything at all..no hard feelings..we all had our share..just be happy for me for anythng..u might say that u heard said this before, lyk i said, its ok for anyone of u not to believe..il do what has to be done..diff folks, diff strokes..i was strippd away of my life..and justice was not served..probably its bec we're in the phils...but then again..its cool...and guysu can check my ms one drive, pictures were saved there, and pictures where they gave me and broken lower lip..when i was crying, begging her to talk to me but instead gave me that..guys its been a pleasure to be here..sorry for the long speech, and probably my last..today, all of the agony, frustrations, and of the negative emotions will come to its end..i jst wanna let everythng go..the entire year was the worst..and knowng that there is no chance for my family to come home, its obvious, the succeeding years will be tge same..i have given enuf, a d foe 8 years, got back nothing in return..if only i an show u my feelings, that might somehow got ur sympathy..but not hers...again, thank u everyone..and i hope none of these happens to anyone of u..tc and god bless..

@gitVictim83

This comment has been minimized.

gitVictim83 commented Dec 3, 2018

And bro...thanks for welcoming me to ur houss and to ur family..sorry i didnt had the chance to catch u to say thanks and gudbye..u knw who u are..no bad blood..for me, were still bros.. "de gustibus non desputandum est..." salute kapatid.. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment