Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language and ROM compatibility for cache deletion via accessibility service. #2396

Open
d4rken opened this Issue Mar 19, 2019 · 12 comments

Comments

Projects
None yet
3 participants
@d4rken
Copy link
Owner

d4rken commented Mar 19, 2019

Support status of #1588 .

Supported since v4.14.0:

  • English (en) (AOSP 6.0 to 9.0)
  • German (de) (AOSP 6.0 to 9.0)
  • Czech (cs) (AOSP 6.0 to 9.0)
  • Russian (ru) (AOSP 6.0 to 9.0, Samsung 8.1)
  • Spanish (es) (AOSP 6.0 to 9.0)
  • Chinese (zh) (AOSP 6.0 to 9.0)
  • Japanese (ja) (AOSP 6.0 to 9.0)

To add support for other languages:

  • State your locale/language, Android version and device.
  • Post the text of step 1 and step 2, so I can copy paste them (in case non Latin characters are used)
  • Add a screenshot of both screens

Step 1 is a list entry that takes us to the app's storage details, in English on Android 9 the entry reads:

Storage
X,XX MB used in internal storage

Screenshot

Step 2 is the button for clearing the cache, in English on Android 9 it's labeled:

Clear cache

Screenshot

@d4rken

This comment has been minimized.

Copy link
Owner Author

d4rken commented Mar 20, 2019

  • Russian (ru) (AOSP 9.0)
    • Item 1 Хранилище
    • Item 2 Очистить кеш
@PauloFerr

This comment has been minimized.

Copy link

PauloFerr commented Mar 26, 2019

Why don't you use views id instead of text?

@d4rken

This comment has been minimized.

Copy link
Owner Author

d4rken commented Mar 27, 2019

@PauloFerr The entries are viewholders in a recyclerview, so they all have the same ID. I tried to use position, but that's variable too (at least between ROMs).

@drezz2

This comment has been minimized.

Copy link

drezz2 commented Apr 2, 2019

Lenguaje:Spanish (es_ES) Version: Lineage 16 Device:Oneplus One

Screenshots

Step 1
imagen

Step2
imagen

I think that in android one (mi a2), it puts it in lowercase, I could confirm it if you want it

@d4rken

This comment has been minimized.

Copy link
Owner Author

d4rken commented Apr 3, 2019

@drezz2 Thanks, SD Maid will figure out lower/upper case herself. So it should work, but it wouldn't hurt if you test it in the next beta 😉.

@drezz2

This comment was marked as off-topic.

Copy link

drezz2 commented Apr 3, 2019

do you see the two images? I do not know the reason why it only shows one (step 2) and the other appears as a link. (step 1)

When you join a beta program, does Google Play only notify you of betas?

@d4rken

This comment was marked as off-topic.

Copy link
Owner Author

d4rken commented Apr 3, 2019

do you see the two images? I do not know the reason why it only shows one (step 2) and the other appears as a link. (step 1)

Sorry I edited your comment to make it smaller, fixed.

When you join a beta program, does Google Play only notify you of betas?

No, you will always get the latest version, if there is no beta then you'll get the production version.

@drezz2

This comment was marked as off-topic.

Copy link

drezz2 commented Apr 3, 2019

ok, so when you update you do not know if it is a beta or final version? (It's just curiosity, I do not know how this works, or if the play store indicates it)

@d4rken

This comment was marked as off-topic.

Copy link
Owner Author

d4rken commented Apr 3, 2019

Google Play does no detection. I tell Google Play where to publish it. Any version that is published as beta on Google Play can also be moved forward to production.

Independent of that when there have been many large changes I build SD Maid with a "beta" flag which will make it show "Beta" in the app too and improve debugging while sacrificing a bit performance. Builds with the "beta" flag will just not be moved to production by me.

Sometimes I think a build is stable but after publishing it on the beta track a few problems arise and I never move that problematic update out of beta, but replace it with an update, and if that update is stable enough I move it forward to production.

@d4rken

This comment has been minimized.

Copy link
Owner Author

d4rken commented Apr 15, 2019

  • Russian (ru) (samsung/gta2slte:8.1.0)
    • Item 1 Память
    • Item 2 Очистить кеш
@d4rken

This comment has been minimized.

Copy link
Owner Author

d4rken commented Apr 16, 2019

  • Chinese (zh) (AOSP 9.0)
    • Item 1 存储
    • Item 2 清除缓存
@d4rken

This comment has been minimized.

Copy link
Owner Author

d4rken commented Apr 16, 2019

  • Japanese (ja) (AOSP 9.0)
    • Item 1 ストレージ
    • Item 2 キャッシュを削除
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.