Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of duplicate bookmark paths in Explorer #2478

Open
mcl21014 opened this Issue Apr 12, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@mcl21014
Copy link

commented Apr 12, 2019

Device: Pixel XL
Android version: 9 Pie PQ2A.190405.003
Root status: Rooted with Magisk 18.1
SD Maid version: 4.14.1
Try to add a bookmark in Explorer for a path to a location that's already bookmarked, say /storage/emulated/0/. You will notice the add button is still present. The user can now add a duplicate bookmark, which will not be reflected in the UI. The button should either be greyed out for consistency's sale, or changed to an edit button. The former would be a better idea.

@d4rken d4rken added this to the Next Tasks milestone Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.