Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanging during setup with bleeding edge Magisk version #2867

Closed
jancm opened this issue Aug 10, 2019 · 12 comments

Comments

@jancm
Copy link

commented Aug 10, 2019

SDMaid 4.14.32
Pixel 3 XL
Q beta 6
I actually managed (somehow) to get process control to successfully scan one time. Haven't been able to do it again.
That one time was missing things like freeze app, or options other than a complete deletion of the app.
Anyway now, no matter what I try, I seem to be in a constant queued state. Also there seems to be an extra process running (e. g. - starry process control, notification says "2 processes running".)
Going back to Pie after posting this . (And with no TWRP for Q yet that's another pain in the butt)
Logs attached.
2019-08-10_10.16-sdmaid.zip

@d4rken

This comment has been minimized.

Copy link
Owner

commented Aug 10, 2019

Can you record a debug log?
https://github.com/d4rken/sdmaid-public/wiki/Reporting-a-bug#debug-log

Hanging at "In queue" is usually a root thing, are you sure Magisk is running correctly?

@jancm

This comment has been minimized.

Copy link
Author

commented Aug 10, 2019

@d4rken

This comment has been minimized.

Copy link
Owner

commented Aug 11, 2019

Also there definitely appeared to be an extra tall running. Try running App
Control notification states that 2 tasks are running. Start
CorpseFinder+SystemCleaner+AppCleaner = 4 tasks running.

The 4th task is the init task that runs once per new SD Maid session.

The other issue, as I mentioned, was the one time I did get App Control to
work there appeared to be options missing.
Didn't spend a ton of time searching but definitely noticed:
No "freeze app" function
No "Reset" option
No "Delete the app, but keeps the data" option.

Those all require root.

Magisk (latest Canary) was definitely working correctly. Titanium, terminal
emulator as root, file explorers, were all processing it correctly (as well
as some scripts and other assorted items).

The issue still points to Magisk, it's not necessarily an Android Q issue though this can happen on any Android version, and can also happen with SuperSU. Under some conditions (that I don't understand), the SuperUser app will just not respond when trying to open a root shell. The fix is usually a reboot, removing the hanging app from it's database, or at worst rerooting.

@jancm

This comment has been minimized.

Copy link
Author

commented Aug 11, 2019

@jancm

This comment has been minimized.

Copy link
Author

commented Aug 12, 2019

@jancm

This comment has been minimized.

Copy link
Author

commented Aug 13, 2019

@d4rken

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

sdmaid_logfile_1565633967448.txt.mgsklog-on.zip

1565633978217  D/RXS:Root:Root: We got ROOT on first try :D !
1565633978217  D/RXS:Root:RootContext: Root: Root(state=ROOTED)

Finishes with AppControl being loaded.

sdmaid_logfile_1565634191091.mgsklog-off.txt.zip

1565634201298  D/RXS:Root:Root: We got ROOT on first try :D !
1565634201298  D/RXS:Root:RootContext: Root: Root(state=ROOTED)
(...)
1565634201350  D/RXS:RxShell:Session: writeLine(line=/data/user/0/eu.thedarken.sdm/files/toybox_sdm touch --help, flush=false)
1565634201351  D/RXS:RxShell:Session: writeLine(line=echo a72cf8bc-1afa-465e-9913-0a3c39330185 $?, flush=false)
1565634201351  D/RXS:RxShell:Session: writeLine(line=echo a72cf8bc-1afa-465e-9913-0a3c39330185 >&2, flush=true)

Hangs on testing touch applet availability.

sdmaid_logfile_1565634376451.mgsklog-off.rootcheck-off.txt.zip

1565634385040  I/RootManager: Initialising RootContext
1565634385040  W/RootManager: Rootcheck is disabled!
1565634385041  I/RootManager: RootContext: RootContext(rootState=Root(state=UNAVAILABLE)

Finishes with AppControl being loaded.

@d4rken

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

I've not seen this behavior before 🤔

Each applet get's checked once against a normal non-root shell and against a root-shell, it hangs on running /data/user/0/eu.thedarken.sdm/files/toybox_sdm touch --help in a root shell.

So the initial root check by just opening a shell via "su" works, we open a shell, check status:

1565634201291  V/RXS:Harvester:Output: uid=0(root) gid=0(root) groups=0(root) context=u:r:magisk:s0

Get this ^ and assume root.

Then applet tests start, the touch one is the first. SD Maid tests it successfully without root and then doesn't get any output when testing it with root.

@d4rken

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

According to SD Maid you have

1565634201236  V/RXS:Harvester:Output: 19.4-736729f5:MAGISKSU

I think this is a beta version? Can you try the latest production Magisk, i.e. 19.3? This might just be a bug in Magisk 19.4.

@d4rken d4rken added bug and removed api: 29-10.0-Q labels Aug 13, 2019

@jancm

This comment has been minimized.

Copy link
Author

commented Aug 13, 2019

@d4rken

This comment has been minimized.

Copy link
Owner

commented Aug 14, 2019

As this is not an issue in SD Maid, I'm closing this here. I've created a ticket with Magisk: topjohnwu/Magisk#1776

Please add any further details there.

@d4rken d4rken closed this Aug 14, 2019

@d4rken d4rken changed the title constant queued state - Q beta 6 Hanging during setup with bleeding edge Magisk version Aug 14, 2019

@d4rken

This comment has been minimized.

Copy link
Owner

commented Aug 14, 2019

@jancm Please confirm the working and non working builds again within the issue ticket on the Magisk repo, are there even closer versions where one works and the other one doesn't? Or have there not been any other versions. This will make it a lot easier to narrow down the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.