New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling causes a crash #323

Closed
geocfu opened this Issue Mar 6, 2016 · 13 comments

Comments

2 participants
@geocfu

geocfu commented Mar 6, 2016

While the operation has started, if i press the cancel button, the app will force close

@d4rken d4rken changed the title from QuickAccess bug to Cancelling causes a crash Mar 6, 2016

@d4rken

This comment has been minimized.

Owner

d4rken commented Mar 6, 2016

A specific tool?

@geocfu

This comment has been minimized.

geocfu commented Mar 6, 2016

I think it does not matter. It has happend on corpse finder and on systemcleaner.

@d4rken

This comment has been minimized.

Owner

d4rken commented Mar 7, 2016

I'm seeing some related crashes in the bug tracker, can you give me your install ID?
It's under Overview > SD Maid, you can tap it to copy the ID to clipboard.
With it i can find the crash report from your device.

@geocfu

This comment has been minimized.

geocfu commented Mar 7, 2016

721382ad-3697-49fd-8416-cec333ca6ac2

@d4rken

This comment has been minimized.

Owner

d4rken commented Mar 7, 2016

Hm weird, only a crash from 4 days ago.

I think i can reproduce it though, not sure if its the same crash but it's when canceling.

@geocfu

This comment has been minimized.

geocfu commented Mar 7, 2016

Do you want me to take a logcat? Just tell me how.

@d4rken

This comment has been minimized.

Owner

d4rken commented Mar 7, 2016

I think doing a debug run while it crashes actually gets the crash own SD Maids own log, that would be cool to try 😎 .

@geocfu

This comment has been minimized.

geocfu commented Mar 7, 2016

Ok i did it twice. So we have a log with no force close while canceling and a log with force close due to canceling. Take a look. Note that in the first scenario when after the cancel there was no force close i closed the app by myself.

sdmaid_logfile_1457365331982NOCRASH.txt
sdmaid_logfile_1457365488554CRASHED.txt

@d4rken

This comment has been minimized.

Owner

d4rken commented Mar 7, 2016

Crash that takes SD Maid doesn't seem to be logged by SD Maid itself, which would explain why I get no automatic crash report from your for that. Not sure why that is, likely doesn't deal well with multithreading.

You could do a normal logcat with an external tool, if you don't that's okay too. I'm pretty sure it only happens if you cancel while a shell using root is open and SD Maid then tries to cancel the root shell.
It tries to get the PID of that shell and crashes while parsing for the PID.

@geocfu

This comment has been minimized.

geocfu commented Mar 7, 2016

Did i got it correct?
locat.txt

@d4rken

This comment has been minimized.

Owner

d4rken commented Mar 7, 2016

Although the file is weirdly formated (open it and see), yes you did the crash is on there 👍

E/AndroidRuntime( 8271): FATAL EXCEPTION: Thread-3144
E/AndroidRuntime( 8271): Process: eu.thedarken.sdm, PID: 8271
E/AndroidRuntime( 8271): java.lang.UnsupportedOperationException
E/AndroidRuntime( 8271):        at java.util.AbstractList.add(AbstractList.java:404)
E/AndroidRuntime( 8271):        at java.util.AbstractList.add(AbstractList.java:425)
E/AndroidRuntime( 8271):        at eu.thedarken.sdm.tools.n.a(PIDKiller.java:66)
E/AndroidRuntime( 8271):        at eu.thedarken.sdm.tools.n.a(PIDKiller.java:103)
E/AndroidRuntime( 8271):        at eu.thedarken.sdm.tools.shell.a.a.i(InteractiveShell.java:415)
E/AndroidRuntime( 8271):        at eu.thedarken.sdm.tools.io.hybrid.d.d.i(HybridReaderStreamer.java:90)
E/AndroidRuntime( 8271):        at eu.thedarken.sdm.systemcleaner.SystemCleanerWorker.a(SystemCleanerWorker.java:62)
E/AndroidRuntime( 8271):        at eu.thedarken.sdm.c.b(AbstractWorker.java:178)
E/AndroidRuntime( 8271):        at eu.thedarken.sdm.c.i(AbstractWorker.java:189)
E/AndroidRuntime( 8271):        at eu.thedarken.sdm.oneclick.t.run(OneClickBox.java:136)
E/AndroidRuntime( 8271):        at java.lang.Thread.run(Thread.java:818)
W/ActivityManager( 2087):   Force finishing activity 1 eu.thedarken.sdm/.SDMMainActivity
@geocfu

This comment has been minimized.

geocfu commented Mar 7, 2016

Great. Waiting for the fix :)

@d4rken d4rken closed this Mar 8, 2016

@d4rken

This comment has been minimized.

Owner

d4rken commented Mar 8, 2016

Should be fixed in v4.0.9

@d4rken d4rken added c: General UI&UX and removed c: Core labels Jul 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment