Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserFilter - File age based filter attribute #333

Closed
debopriyobasu opened this issue Mar 26, 2016 · 22 comments
Closed

UserFilter - File age based filter attribute #333

debopriyobasu opened this issue Mar 26, 2016 · 22 comments

Comments

@debopriyobasu
Copy link

@debopriyobasu debopriyobasu commented Mar 26, 2016

Hello! We make backups of many apps/chats of WhatsApp for which we only need the latest backup of the app/chat.Any old backups consume storage space and I would request SD Maid Dev to incorporate a user filter with "keep newest" option in system cleaner so that the old backups get deleted automatically.

@sonyjosephk
Copy link

@sonyjosephk sonyjosephk commented Mar 27, 2016

I completely agree with you. It's very must and also allow us to analyze individual directory were Duplicate files can be deleted.

Loading

@d4rken
Copy link
Owner

@d4rken d4rken commented Mar 27, 2016

@sonyjosephk What do you mean? You can already add specific scanpaths to the duplicates tool? What does this have to do with this ticket?

Loading

@sonyjosephk
Copy link

@sonyjosephk sonyjosephk commented Mar 27, 2016

Darken,

Coz, your Duplicate Finder fails to recognize it in-spite of specifying the
"Path"
On Mar 27, 2016 18:03, "Matthias Urhahn" notifications@github.com wrote:

@sonyjosephk https://github.com/sonyjosephk What do you mean? You can
already add specific scanpaths to the duplicates tool? What does this have
to do with this ticket?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#333 (comment)

Loading

@d4rken
Copy link
Owner

@d4rken d4rken commented Mar 27, 2016

WhatsApp backups are not duplicate files.

Loading

@sonyjosephk
Copy link

@sonyjosephk sonyjosephk commented Mar 27, 2016

Darken,

I am also an tester for Microsoft and I know that WhatsApp backup does not
have Duplicate files but if you read the original post then you woukd
understand what he meant...

You just can't sound rude. Anyways, I am in a Easter Mood and celebrating
it with my family and closed friends in India.

Regard,
Sony Joseph

WhatsApp backups are not duplicate files.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#333 (comment)

Loading

@d4rken
Copy link
Owner

@d4rken d4rken commented Mar 27, 2016

I'm not trying to be rude.
I understand the original ticket, but I don't understand your comments.

It's very must and also allow us to analyze individual directory were Duplicate files can be deleted.

What does that mean?

Loading

@sonyjosephk
Copy link

@sonyjosephk sonyjosephk commented Mar 27, 2016

Well reply on this later...
On Mar 27, 2016 21:05, "Matthias Urhahn" notifications@github.com wrote:

I understand the original ticket, I don't understand your comments.

It's very must and also allow us to analyze individual directory were
Duplicate files can be deleted.

What does that mean?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#333 (comment)

Loading

@d4rken
Copy link
Owner

@d4rken d4rken commented Mar 28, 2016

Suspects

shell@hammerhead:/sdcard/WhatsApp $ ls -la Databases/
-rw-rw---- root     sdcard_rw  4314259 2016-03-20 02:00 msgstore-2016-03-21.1.db.crypt8
-rw-rw---- root     sdcard_rw  4318019 2016-03-21 02:00 msgstore-2016-03-22.1.db.crypt8
-rw-rw---- root     sdcard_rw  4322675 2016-03-22 02:00 msgstore-2016-03-23.1.db.crypt8
-rw-rw---- root     sdcard_rw  4325811 2016-03-23 02:00 msgstore-2016-03-24.1.db.crypt8
-rw-rw---- root     sdcard_rw  4337299 2016-03-24 02:00 msgstore-2016-03-25.1.db.crypt8
-rw-rw---- root     sdcard_rw  4404835 2016-03-25 02:00 msgstore-2016-03-26.1.db.crypt8
-rw-rw---- root     sdcard_rw  4413763 2016-03-26 02:00 msgstore-2016-03-27.1.db.crypt8
-rw-rw---- root     sdcard_rw  4449651 2016-03-27 03:00 msgstore-2016-03-28.1.db.crypt8
-rw-rw---- root     sdcard_rw  4524803 2016-03-28 02:00 msgstore.db.crypt8

Loading

@d4rken d4rken changed the title "Keep Newest" user filter to delete old WhatsApp backups UserFilter - File age based filter attribute Jul 16, 2016
@d4rken
Copy link
Owner

@d4rken d4rken commented Jul 16, 2016

What I'd like to see is the ability to periodically delete photos that are of a certain age and older.

In the Last Modified view I can return a list by modifying the settings of directory location and min/max > age. It would be great to be able to select all those files returned in the list for deletion.
Another idea would be to add modification date as a new criteria for a custom filter in System Cleaner, > this would also have the benefit of being able to run from the Scheduler.

Loading

@undersound
Copy link

@undersound undersound commented Feb 10, 2017

I would love to see this feature as well.
A Date From / Date To option in the User section of Filter manager would work for my use case.

Loading

@d4rken d4rken added this to the Next Tasks milestone Feb 11, 2017
@d4rken d4rken removed this from the Blue Sky milestone Feb 11, 2017
@d4rken
Copy link
Owner

@d4rken d4rken commented Feb 11, 2017

Maybe just a date/timepicker combo?

@undersound If you are willing to manually edit a filter (e.g. no ui), I could give you a test version.

Loading

@d4rken d4rken removed this from the Next Tasks milestone Feb 11, 2017
@d4rken d4rken added this to the v4.6.3 milestone Feb 11, 2017
@d4rken d4rken added this to the v4.6.3 milestone Feb 11, 2017
@d4rken d4rken removed this from the Next Tasks milestone Feb 11, 2017
@d4rken
Copy link
Owner

@d4rken d4rken commented Feb 11, 2017

Actually we wouldn't want a timepicker combo, because matching needs to be relative.
So we need somekind of slider for "older than X days"?

Loading

@d4rken d4rken added this to the Blue Sky milestone Feb 14, 2017
@d4rken d4rken removed this from the v4.6.3 milestone Feb 14, 2017
@d4rken d4rken added this to the Next Tasks milestone Feb 14, 2017
@d4rken d4rken removed this from the Blue Sky milestone Feb 14, 2017
@undersound
Copy link

@undersound undersound commented Feb 21, 2017

Just out of curiousity why does matching needs to be relative?

So we need somekind of slider for "older than X days"?

This would already be realy nice to have

Loading

@d4rken
Copy link
Owner

@d4rken d4rken commented Feb 21, 2017

Someone creating a filter wants files older than X days, if we save an actual date, and time progresses (as it naturally does), "older than X" value would steadily increase. So we need to save a relative time value.

Probably time in miliseconds, then we just check currentTime - file.getModTime() > filter.getMinAge() something like that.

Loading

@undersound
Copy link

@undersound undersound commented Feb 21, 2017

For scheduled runs it makes a lot more sense indeed.

Loading

@d4rken d4rken added this to the Next Update milestone May 13, 2017
@d4rken d4rken removed this from the Next Tasks milestone May 13, 2017
@d4rken d4rken closed this May 13, 2017
@d4rken
Copy link
Owner

@d4rken d4rken commented May 13, 2017

https://github.com/d4rken/sdmaid-public/wiki/SystemCleaner#minimum-age

Next update.
If someone comes up with a good whatsapp filter we could add it as default.

Loading

@antonio-gil
Copy link

@antonio-gil antonio-gil commented May 19, 2017

Well, after a brief testing (almost since you've replied on Reddit), I've came up with a filter that considers all backups that are older than today (as WA makes a daily backup in my case) to be deleted.

So far, it works as intended (IMHO), so I can share (just need to know how haha) it to be evaluated by the community.

Loading

@d4rken
Copy link
Owner

@d4rken d4rken commented May 19, 2017

Loading

@antonio-gil
Copy link

@antonio-gil antonio-gil commented May 19, 2017

Perhaps I'm doing something wrong, but is not exporting anything...

Is should be looking for which file type?

Loading

@d4rken
Copy link
Owner

@d4rken d4rken commented May 19, 2017

Did it say 1 OK at the bottom after exporting? The file looks like abe1234fef.scuf.sdm.json. Default path should be <sdcard>/Download.

Loading

@antonio-gil
Copy link

@antonio-gil antonio-gil commented May 19, 2017

Oddly, I was able to see the file on the device file explorer but not via Windows Explorer (as if it has the "hidden" attribute)

Here is the exported file.

Regards!

Loading

@d4rken
Copy link
Owner

@d4rken d4rken commented May 19, 2017

Awesome!

I've made a few more tweaks and added some explanations.
Lets continue this here #904

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants