New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle busybox segmentation fault (139) #397

Closed
d4rken opened this Issue May 29, 2016 · 1 comment

Comments

1 participant
@d4rken
Owner

d4rken commented May 29, 2016

It seems a busybox can both return valid data and exit with code 139 (segfault) and the error message "Segmentation fault".

The busybox setup doesn't abort on this error because it still sees correct results, but the error persists on all busybox actions and causes other operations that don't accept non 0 exitcodes to fail.

1464493387174 D/SDM:Binary:BusyboxTester: BB Version, Exitcode:0
1464493387174 I/SDM:Binary:BusyboxTester: BusyBox Version:BusyBox v1.22.2-Doriman
1464493387174 I/SDM:Binary:BusyboxTester: Testing /system/xbin/busybox [Type:SYSTEM] testWithRoot:true
1464493387175 V/SDM:Shell:StaticExecutor: SHELLDELAY:100
1464493387175 V/SDM:Shell:StaticExecutor: trying to execute as root
1464493387323 V/SDM:Shell:StaticExecutor: $BUSYBOX find \/data -maxdepth 0  -print0 | $BUSYBOX xargs -0 $BUSYBOX stat -c "%a:%F:%d:%i:%u:%g:%s:%Z:%N"
1464493387370 V/SDM:StreamHarvester: Output:771:directory:45853:2:1000:1000:4096:1464415649:/data
1464493387371 V/SDM:StreamHarvester: Error:Segmentation fault 
1464493387624 V/SDM:Shell:StaticExecutor: Exitcode: 139
1464493387624 V/SDM:Shell:StaticExecutor: Destroying Executor
1464493387625 I/SDM:Binary:BusyboxTester: Whoops, Exitcode was:139
1464493387625 D/SDM:Binary:BusyboxTester: 771:directory:45853:2:1000:1000:4096:1464415649:/data
1464493387625 D/SDM:Binary:BusyboxTester: Segmentation fault 
1464493387625 W/SDM:Binary:BusyboxTester: Error on exitcode, but '/system/xbin/busybox' works with root
1464493387626 I/SDM:Binary:BusyboxTester: Works (withRoot:true):'/system/xbin/busybox'
1464493387626 I/SDM:Binary:SystemNativeRootModule: System binary is compatible and works with root, will use it
@d4rken

This comment has been minimized.

Owner

d4rken commented Jun 18, 2016

On 13 Jan 2014 in v3.0.1.9 I fixed an issue regarding ECHILD errors and busyboxes, that commit also changed the code to try to gracefully continue... Well turns out that wasn't a good idea 😲.

@d4rken d4rken closed this Jun 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment