New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored settings cause app to clean without its permissions #435

Closed
sjoshua270 opened this Issue Jul 10, 2016 · 9 comments

Comments

2 participants
@sjoshua270

sjoshua270 commented Jul 10, 2016

I recently reset my phone to factory settings and had it restore SD Maid. Last night, the cleaning process was triggered, but the app did not have storage access. I had to force close the app and re-open it to grant the storage permission

@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 10, 2016

What behavior would you expect from SD Maid?

How did you restore SD Maid?

@sjoshua270

This comment has been minimized.

sjoshua270 commented Jul 11, 2016

If SD Maid could leave a notification mentioning that the permission had not been granted, that would be useful. This would only need to happen after a scheduled task fails.

The problem is that all of the app's settings had been restored, and that caused the scheduled tasks to run even though I hadn't opened the app since the factory reset. They were trying to do their operations, but couldn't.

I had to force close the app from android settings before I was able to control the app again and grant the storage permission. Then everything ran fine.

@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 11, 2016

Did you reboot your device after restoring the app?
The reboot could have theoretically reinstantiated the alarm.
Though in the default state the boot receiver doing this should be disabled...
I'll look into that.

I'll probably add a notification that says something a long "Setup required".

How did you restore SD Maid?

Titanium Backup?

@sjoshua270

This comment has been minimized.

sjoshua270 commented Jul 15, 2016

Oh I see what you mean by 'restore'. I didn't use anything like Titanium Backup.
I set up my phone to restore from my previous setup (which Google had stored).
I suppose the restore came from Google. I know that some developers have enabled their apps to backup data with Google. If you have enabled it in this app, my previous settings probably restored through that service.

@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 15, 2016

Hm I never neither enabled it nor disabled it, I think it's default=on since 6.0+.

@sjoshua270

This comment has been minimized.

sjoshua270 commented Jul 15, 2016

No, I think they disable it by default because of the way different apps handle/encrypt their data.
Anyway, somehow my scheduled task was triggered before I opened the app to enable permissions. Thanks for the awesome app and thanks for being so responsive to feedback :)

@sjoshua270

This comment has been minimized.

sjoshua270 commented Jul 15, 2016

Here: I believe you have to register for it and set it up: https://developer.android.com/guide/topics/data/backup.html#BackupManifest

@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 15, 2016

Please post your device info and SD Maid version.

@d4rken d4rken added bug and removed 0 needs info/repro labels Jul 15, 2016

@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 15, 2016

Fix committed to v4.3.0

@d4rken d4rken closed this Jul 15, 2016

@d4rken d4rken added this to the v4.3.0 milestone Jul 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment