New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit toast has black font #438

Closed
TWiStErRob opened this Issue Jul 16, 2016 · 7 comments

Comments

2 participants
@TWiStErRob

TWiStErRob commented Jul 16, 2016

Minor UI cosmetic issue:
screenshot_2016-07-16-15-27-10

@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 17, 2016

Thanks for the report.
What ROM / device is this?
It doesn't look like the default toast message theme at all.

Is this a recent issue or has it always been the case?

@TWiStErRob

This comment has been minimized.

TWiStErRob commented Jul 17, 2016

I don'k now if it's changed since earlier versions, it's a brand new stock Galaxy S5 Andorid 5.0.

You might be using a custom view for it, because the device default doesn't look like that: In my app, I have black text on white and the corners are not that rounded (quickly added a toast to my app):
image

I'm using a theme that extends Theme.AppCompat.Light, but it looks the same with Theme.AppCompat (above screenshot is with latter). Code is:

Toast.makeText(getApplicationContext(), "Press twice to exit.", Toast.LENGTH_LONG).show();
@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 17, 2016

Found it. I'm using the base context which AFAIK doesn't get a theme applied.
Not sure why, probably a typo.

Toast.makeText(getBaseContext(), R.string.double_tap_to_exit, Toast.LENGTH_SHORT).show();

@d4rken d4rken added bug and removed 0 needs info/repro labels Jul 17, 2016

@d4rken d4rken added this to the v4.3.0 milestone Jul 17, 2016

@d4rken d4rken closed this Jul 17, 2016

@TWiStErRob

This comment has been minimized.

TWiStErRob commented Jul 17, 2016

Huh, you're right; that's good to know, here's test for posterity (using Theme.AppCompat.Light):

Toast.makeText(getApplicationContext(), "app", Toast.LENGTH_LONG).show();
Toast.makeText((Activity)this, "this", Toast.LENGTH_LONG).show();
Toast.makeText(this.getBaseContext(), "base", Toast.LENGTH_LONG).show();

image
image
image

@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 17, 2016

👍 Are those just screenshots or do you have a cool tool for these tests :)?

I'm suprised by the difference between the application context and the activity though...

@TWiStErRob

This comment has been minimized.

TWiStErRob commented Jul 17, 2016

Yeah, the activity and application should look the same, especially since they have the same theme, maybe it's appcompat, because it's not wrapping App extends Application.
I just put those 3 lines into my main activity and took 3 shots quickly, no magic tool (except maybe IrfanView for cropping).

@d4rken

This comment has been minimized.

Owner

d4rken commented Jul 17, 2016

On my N9@Nougat & N5@6.0 all 3 cases look the same (case "this").
Don't have a Samsung device at hand atm.
Definitely interesting.

Guessing: TouchWiz overrides the APP theme/styles somewhere but not the ACTIVITY theme/styles? Maybe this is a bug in TouchWiz where they forgot to alter all necessary styles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment