New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash during StorageManager initialization #475

Closed
d4rken opened this Issue Sep 3, 2016 · 2 comments

Comments

1 participant
@d4rken
Owner

d4rken commented Sep 3, 2016

Process: eu.thedarken.sdm
Flags: 0x98be44
Package: eu.thedarken.sdm v40300 (4.3.0)
Build: samsung/serranoltexx/serranolte:4.4.2/KOT49H/I9195XXUCOB1:user/release-keys

java.lang.NullPointerException
    at eu.thedarken.sdm.tools.storage.g.a(StorageHelper.java:29)
    at eu.thedarken.sdm.tools.storage.a.k.a(PrivateDataModule.java:41)
    at eu.thedarken.sdm.tools.storage.e.a(StorageFactory.java:114)
    at eu.thedarken.sdm.tools.storage.h.d(StorageManager.java:69)
    at eu.thedarken.sdm.tools.storage.h.<init>(StorageManager.java:40)
    at eu.thedarken.sdm.o.g(SDMContext.java:156)
    at eu.thedarken.sdm.o.a(SDMContext.java:187)
    at eu.thedarken.sdm.c$1.run(BaseConditions.java:6169)
    at eu.thedarken.sdm.u$1.run(WorkerOverlord.java:94)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
    at eu.thedarken.sdm.r$1.run(SDMThreadFactory.java:57)
    at java.lang.Thread.run(Thread.java:841)

Device is rooted and has an external sdcard.

SuperSU 2.78.

@d4rken d4rken added this to the v4.3.1 milestone Sep 3, 2016

@d4rken

This comment has been minimized.

Owner

d4rken commented Sep 3, 2016

Should crash SD Maid when starting any action and the StorageManager initializes.
Not sure yet why it only happens on some devices.

@d4rken

This comment has been minimized.

Owner

d4rken commented Sep 4, 2016

Fixed.

Core

  • Added: If a tool can't find any storage (why?), that tool will now display an error instead of crashing SD Maid.
  • Improved: Display of error messages in tools.
  • Fixed: Crash on devices where SD Maid used rootfs injection to get a working binary. Despite having root, SD Maid didn't use when looking up mounts, causing that to fail and SD Maid ending up with no detected storages (#475 Ty Sandris).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment