New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOException thrown when trying to get back from directory /storage/emulated/0 in SystemExplorer #483

Closed
Solomon1732 opened this Issue Sep 7, 2016 · 7 comments

Comments

2 participants
@Solomon1732

Solomon1732 commented Sep 7, 2016

When in head directory (mentioned above) I expect the "back" button to open the menu, and then exit with more presses (like in the other places in the app). Instead it throws and IOException.

Steps to reproduce:

  1. Enter SystemExplorer
  2. Go to said directory (if not there)
  3. Press the green button
  4. Press the Android "back" button

At this point an exception should be thrown.
screenshot_2016-09-07-13-00-35

It shows up even if the "explore" (green) button has not been pressed:
screenshot_2016-09-07-13-01-34

Shows up when manually opening the menu:
screenshot_2016-09-07-13-02-18

Android type: android 6 marshmallow
Phone type: LG G4 beat
Directory path: /storage/emulated/0
SD Maid version: 4.2.13

@Solomon1732 Solomon1732 changed the title from IOException thrown when trying to get back from directory /storage/emulated/ to IOException thrown when trying to get back from directory /storage/emulated/0 in SystemExplorer Sep 7, 2016

@d4rken d4rken added the c: Explorer label Sep 7, 2016

@d4rken

This comment has been minimized.

Owner

d4rken commented Sep 7, 2016

I agree the current behavior isn't optiomal.
If we open the navigationdrawer on IOExceptions though wouldn't that seem confusing to the user?

@Solomon1732

This comment has been minimized.

Solomon1732 commented Sep 7, 2016

Should the user be exposed to exceptions?
I know I don't want to be exposed. Imagine having an exception message
popping up while playing Call of Duty, or using Gmail. Such an exception
might be confusing if you have no idea what an exception means. As a user
you also don't need to know such a thing exists.
Exceptions are excellent for developers, but most people aren't developers.

My intuitive expectation is for the menu to open if I'm in the root (or
this case's equivalent: /storage/emulated/0/).
Another response might be some message to the user informing them "sorry
bub, but that's as back as you can go."
This is my opinion. Perhaps a discussion would help to think of a response
more optimal than what is currently implemented?

On Wed, Sep 7, 2016, 16:31 Matthias Urhahn notifications@github.com wrote:

I agree the current behavior isn't optiomal.
If the open the navigationdrawer on IOExceptions though wouldn't that seem
confusing to the user?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#483 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APsSTyIr6l5ak4DtCGFaoWu2nqVm8kbVks5qnrzEgaJpZM4J2xDP
.

@d4rken

This comment has been minimized.

Owner

d4rken commented Sep 7, 2016

Should the user be exposed to exceptions? I know I don't want to be exposed.

If something isn't possible it should be made visible to the user. I'm always in favor in making a maximum of information available.

Imagine having an exception message popping up while playing Call of Duty, or using Gmail. Such an exception might be confusing if you have no idea what an exception means.

A message popup is something different from a snackbar, the first keeps you from interacting which other UI elements while the snackbar does not.

As a user you also don't need to know such a thing exists. Exceptions are excellent for developers, but most people aren't developers.

Users still need to know about errors, I agree the message is not optimal and could be replaced with "Error: something".

My intuitive expectation is for the menu to open if I'm in the root (or this case's equivalent: /storage/emulated/0/). Another response might be some message to the user informing them "sorry bub, but that's as back as you can go." This is my opinion. Perhaps a discussion would help to think of a response more optimal than what is currently implemented?

The thing is only /storage/emulated is off limits, the user can press go to / other /system so it's not as far as the user can go. How far actually depends on each ROM and might be quite arbitrary...

Hm so what shall we do?

  • Reword the error message

Maybe try to "jump" not accessible error messages? So if /storage/emulated is off limits, retry with /storage or / and once we are at / the default back button behavior kicks in anyways.

@d4rken d4rken added this to the Next Tasks milestone Sep 7, 2016

@Solomon1732

This comment has been minimized.

Solomon1732 commented Sep 8, 2016

Maybe both? Printing something like "/storage/emulated is not accessible,
go to /storage instead?" and giving the user a choice?

From the discussion I can see there are at least five ways to handle it:

  1. Leave it as it is
  2. Changing the error message
  3. "Silently" jumping over /storage/emulated
  4. Printing a changed error message and prompting the user with a choice to
    stay in the current directory or jumping to /storage
  5. Jumping without user choice and explaining the reason for it in a
    snackbar (or something along the line)

On Thu, Sep 8, 2016 at 12:44 AM Matthias Urhahn notifications@github.com
wrote:

Should the user be exposed to exceptions? I know I don't want to be
exposed.

If someone isn't possible it should be made visible to the user. I'm
always in favor in making a maximum of information available.

Imagine having an exception message popping up while playing Call of Duty,
or using Gmail. Such an exception might be confusing if you have no idea
what an exception means.

A message popup is something different from a snackbar, the first keeps
you from interacting which other UI elements while the snackbar does not.

As a user you also don't need to know such a thing exists. Exceptions are
excellent for developers, but most people aren't developers.

Users still need to know about errors, I agree the message is not optimal
and could be replaced with "Error: something".

My intuitive expectation is for the menu to open if I'm in the root (or
this case's equivalent: /storage/emulated/0/). Another response might be
some message to the user informing them "sorry bub, but that's as back as
you can go." This is my opinion. Perhaps a discussion would help to think
of a response more optimal than what is currently implemented?

The thing is only /storage/emulated is off limits, the user can press go
to / other /system so it's not as far as the user can go. How far
actually depends on each ROM and might be quite arbitrary...

Hm so what shall we do?

  • Reword the error message

Maybe try to "jump" not accessible error messages? So if /storage/emulated
is off limits, retry with /storage or / and once we are at / the default
back button behavior kicks in anyways.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#483 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APsST03smb1yrDZvAAnmUe9SQL4QSPgHks5qnzA8gaJpZM4J2xDP
.

@d4rken d4rken added enhancement and removed needs discussion labels Sep 8, 2016

@d4rken d4rken modified the milestones: v4.3.3, Next Tasks Sep 17, 2016

@d4rken

This comment has been minimized.

Owner

d4rken commented Sep 17, 2016

Just removed the IO Exception text for now, not happy with any of the alternatives.

@d4rken d4rken closed this Sep 17, 2016

@Solomon1732

This comment has been minimized.

Solomon1732 commented Sep 18, 2016

Seems it's the same problem trying to step from / to /emulated

On Sat, Sep 17, 2016, 12:35 Matthias Urhahn notifications@github.com
wrote:

Just removed the IO Exception text for now, not happy with any of the
alternatives.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#483 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APsSTxxr-7al_S59WkccuEAowVCrigSJks5qq7R4gaJpZM4J2xDP
.

@d4rken

This comment has been minimized.

Owner

d4rken commented Sep 18, 2016

Yeah there are multiple locations with this behavior.

Maybe in an extra ticket we could think about allowing the explorer to "enter" these directories but display a "permission denied" in the main window instead of a list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment