New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome custom tabs aren't in AppTheme style #576

Closed
AndreaCioccarelli opened this Issue Oct 23, 2016 · 2 comments

Comments

2 participants
@AndreaCioccarelli

AndreaCioccarelli commented Oct 23, 2016

The SD-maid dark material theme is very good, but it isn't adapted at the chrome custom tabs module: It isn't according to the google material guidelines.
to fix this "Graphical Bug" simply retrive the Custom Tabs Code and rewrite it applying these code patches:

String url = "https://sdmaid.darken.eu/";
CustomTabsIntent.Builder builder = new CustomTabsIntent.Builder();
//Before builder construction edit object proprieties
builder.setToolbarColor(getResources().getColor(R.colors.colorPrimaryDark));
builder.setStartAnimations(this, R.anim.slide_in_right, R.anim.slide_out_left);
builder.setExitAnimations(this, R.anim.slide_in_left, R.anim.slide_out_right);
CustomTabsIntent customTabsIntent = builder.build();
customTabsIntent.launchUrl(this, Uri.parse(url));

screenshot_20161022-202543

@d4rken

This comment has been minimized.

Owner

d4rken commented Oct 23, 2016

What would happen if the user doesn't have Chrome?

@AndreaCioccarelli

This comment has been minimized.

AndreaCioccarelli commented Oct 23, 2016

The Chrome Custom Tabs library normally start an Intent to respond at HTTPS:// protocol if it the class have detect chrome installed. You have only to write this code, the Chrome class craft automatically the Intent

@d4rken d4rken modified the milestones: v4.4.0, Next Tasks Oct 28, 2016

@d4rken d4rken closed this Oct 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment