New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when folder not found in Explorer #612

Closed
Gitoffthelawn opened this Issue Dec 7, 2016 · 4 comments

Comments

2 participants
@Gitoffthelawn

Gitoffthelawn commented Dec 7, 2016

Error displayed when folder not found in Explorer

To reproduce:

  1. Open SDMaid's Explorer.
  2. Go to a folder.
  3. Terminate SDMaid.
  4. Open another file manager.
  5. Use another file manager to delete the folder from Step 2.
  6. Go back to SDMaid.
  7. The following error is issued: java.io.IOException: Can't access: [folder]

Recommendation:

Indicate that the folder is not present without having a code exception.
For example: "Folder [folder] no longer present."

Tested with SDMaid v4.4.1.

@d4rken

This comment has been minimized.

Owner

d4rken commented Dec 7, 2016

We don't know though whether the folder is "not present", it could just have permissions that don't allow us to read it.

@Gitoffthelawn

This comment has been minimized.

Gitoffthelawn commented Dec 7, 2016

Hmmm.... good point. The folder (and error) was:
java.io.IOException: Can't access: /data/app-lib/[app package name]

I verified that the [app package name] was installed.

@d4rken

This comment has been minimized.

Owner

d4rken commented Dec 8, 2016

The (on purpose) vague description of "Can't access" is displayed whenever SD Maid tries to read something that returns empty results. So I think we can keep it this way as there is no good alternative?

@d4rken d4rken closed this Dec 8, 2016

@Gitoffthelawn

This comment has been minimized.

Gitoffthelawn commented Dec 8, 2016

I agree. I think instead of issuing:
java.io.IOException: Can't access: [folder]

issue:

Can't access: [folder]

And, if possible, indicate why (missing folder, lack of permissions, etc.).

@d4rken d4rken reopened this Dec 8, 2016

@d4rken d4rken modified the milestones: Next Tasks, v4.5.0 Dec 8, 2016

@d4rken d4rken closed this Dec 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment