Fixed issue with filters on number columns, the values come through f…

…rom the client as number, so casting as string doesn't work
d4software · Jan 27, 2018 · 7a80fff · 7a80fff
1 parent 00cdb40
commit 7a80fff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Engine/FilterNode.cs b/Engine/FilterNode.cs
@@ -50,7 +50,7 @@ public override void UpdateSettings(Dictionary<string, object> settings)
                 FilterCompareColumnIndex = Convert.ToInt32(settings["FilterCompareColumnIndex"]);
 
             if (settings.ContainsKey("FilterValue1"))
-                FilterValue1 = (string)settings["FilterValue1"];
+                FilterValue1 = settings["FilterValue1"].ToString();
             else
                 FilterValue1 = null;
 

diff --git a/Tests/FilterTests.cs b/Tests/FilterTests.cs
@@ -23,7 +23,7 @@ private string NodesJsonGreaterThan
                         ""Type"": ""Filter"",
                         ""FilterColumnIndex"": 0,
                         ""Operator"": ""GreaterThan"",
-                        ""FilterValue1"": ""5""
+                        ""FilterValue1"": 5
                     }
                 ]";
 			}