EventEmitter and detail::event_emitter classes take callback object a…

…s const reference instead of 'value copy'
d5 · Feb 22, 2012 · 5079214 · 5079214
1 parent 04fd5a2
commit 5079214
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/native/detail/base.h b/native/detail/base.h
@@ -248,7 +248,7 @@ namespace native
 
         public:
             template<typename T>
-            void* add(T callback, bool once=false)
+            void* add(const T& callback, bool once=false)
             {
                 if(!callbacks_)
                 {
@@ -265,7 +265,7 @@ namespace native
             }
 
             template<typename T>
-            static void add(void* target, T callback, bool once=false)
+            static void add(void* target, const T& callback, bool once=false)
             {
                 auto self = reinterpret_cast<event_emitter*>(target);
                 assert(self);

diff --git a/native/events.h b/native/events.h
@@ -217,7 +217,7 @@ namespace native
          *                      If EventEmitter fails to add the listener, it returns nullptr.
          */
         template<typename E>
-        listener_t addListener(typename E::callback_type callback)
+        listener_t addListener(const typename E::callback_type& callback)
         {
             auto s = events_.find(typeid(E).hash_code());
             if(s != events_.end())
@@ -238,7 +238,7 @@ namespace native
          *                      If EventEmitter fails to add the listener, it returns nullptr.
          */
         template<typename E>
-        listener_t on(typename E::callback_type callback)
+        listener_t on(const typename E::callback_type& callback)
         {
             return addListener<E>(callback);
         }
@@ -253,7 +253,7 @@ namespace native
          *                      If EventEmitter fails to add the listener, it returns nullptr.
          */
         template<typename E>
-        listener_t once(typename E::callback_type callback)
+        listener_t once(const typename E::callback_type& callback)
         {
             auto s = events_.find(typeid(E).hash_code());
             if(s != events_.end())